Skip to content

Show app version in app detail sidebar - #18912

Closed
tcitworld wants to merge 1 commit into
masterfrom
feature/add-version-on-app-detail-view
Closed

Show app version in app detail sidebar#18912
tcitworld wants to merge 1 commit into
masterfrom
feature/add-version-on-app-detail-view

Conversation

@tcitworld

Copy link
Copy Markdown
Member

Show either installed version or first release found in app store data.

Version is shown in the list view but not in the detail sidebar.

It shows on the next line but maybe we can decide a better display.

Screenshot_2020-01-15 Applications - Nextcloud

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just show it in the same row of the license for simplicity?

Version 1.1.4, AGPL-licensed

@skjnldsv

Copy link
Copy Markdown
Member

Well, to be fair the app sidebar is not even using the appsidebar component properly, so moving to it could put both of them on the same line as the subtitle ;)

Show either installed version or first release found in app store data
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld
tcitworldforce-pushed the feature/add-version-on-app-detail-view branch from 1afaa2f to d5d4e71CompareJanuary 16, 2020 08:49
@tcitworld

Copy link
Copy Markdown
MemberAuthor

Can we just show it in the same row of the license for simplicity?

Fixed
Screenshot_2020-01-16 Applications - Nextcloud-2

Well, to be fair the app sidebar is not even using the appsidebar component properly, so moving to it could put both of them on the same line as the subtitle ;)

@skjnldsv I gave a look but unfortunately we have the app icon in the title, so we're blocked with this right now.

Screenshot_2020-01-16 Applications - Nextcloud

@jancborchardtjancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great now! :)

@skjnldsv

Copy link
Copy Markdown
Member

Could we instead wait for #18969 🙈
Or base those changes on it? :D

@tcitworld

Copy link
Copy Markdown
MemberAuthor

@skjnldsv Yeah feel free to put the commit into #18969 and close this.

@gary-kimgary-kim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking

@tcitworld

Copy link
Copy Markdown
MemberAuthor

This is probably not needed anymore since we have the Changelog tab in the sidebar. I'd be happy to bring it back if needed.

@skjnldsv@jancborchardt

@skjnldsv
skjnldsv deleted the feature/add-version-on-app-detail-view branch June 25, 2021 13:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@tcitworld@skjnldsv@jancborchardt@juliusknorr@gary-kim