Skip to content

Migrate app management settings to proper sidebar standards - #18969

Merged
MorrisJobke merged 2 commits into
masterfrom
enh/apps/use-sidebar
Aug 14, 2020
Merged

Migrate app management settings to proper sidebar standards#18969
MorrisJobke merged 2 commits into
masterfrom
enh/apps/use-sidebar

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Jan 18, 2020

Copy link
Copy Markdown
Member

dev skjnldsv com_settings_apps_enabled_password_policy (1)

@skjnldsvskjnldsv changed the title Enh/apps/use sidebarMigrate apps to proper sidebar standardsJan 18, 2020
@skjnldsvskjnldsv added this to the Nextcloud 19 milestone Jan 18, 2020
@juliusknorr

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@juliusknorr
juliusknorrforce-pushed the enhancement/migrate-to-nextcloud-vue-1 branch from 1bc89b4 to 05742c0CompareJanuary 22, 2020 16:34
@jancborchardtjancborchardt changed the title Migrate apps to proper sidebar standardsMigrate app management settings to proper sidebar standardsJan 27, 2020
@skjnldsv
skjnldsvforce-pushed the enh/apps/use-sidebar branch 3 times, most recently from 17687be to 434d2c4CompareFebruary 5, 2020 14:35
@skjnldsv
skjnldsv changed the base branch from enhancement/migrate-to-nextcloud-vue-1 to masterFebruary 5, 2020 14:36
This was referenced Apr 4, 2020
@MorrisJobke

This comment has been minimized.

@skjnldsv
skjnldsvforce-pushed the enh/apps/use-sidebar branch from 434d2c4 to a353876CompareJuly 9, 2020 16:14
@skjnldsv

This comment has been minimized.

@skjnldsvskjnldsv added the bug label Aug 7, 2020
@MorrisJobkeMorrisJobke mentioned this pull request Aug 11, 2020
57 tasks
@MorrisJobke

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@skjnldsv

This comment has been minimized.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the enh/apps/use-sidebar branch 2 times, most recently from ed8a013 to 72e32b4CompareAugust 14, 2020 09:39
@skjnldsv
skjnldsv marked this pull request as ready for review August 14, 2020 09:40
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 14, 2020
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the enh/apps/use-sidebar branch from 72e32b4 to 8e7c95eCompareAugust 14, 2020 09:44
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Ready to review!
@jancborchardt we should really consider moving to different tabs. Some apps are really crowded 😕
Maybe |Description|Management|Changelog| ?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Also, might be papercuts. Please ignore and we'll fix later :)

@juliusknorr

Copy link
Copy Markdown
Member

Ready to review!
@jancborchardt we should really consider moving to different tabs. Some apps are really crowded confused
Maybe |Description|Management|Changelog| ?

Definitely, maybe we show the management tab first for installed apps, since then you are probably no longer interested in the description. Tabs were planned for #21082 anyways

@faily-bot

faily-botBot commented Aug 14, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31793: failure

mariadb10.4-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\SystemTag\SystemTagManagerTest::testGetAllTags with data set #2 (array(array('one', false, false), array('one', true, false), array('one', false, true), array('one', true, true), array('two', false, false), array('two', false, true)))
Failed asserting that false is true.
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:122

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit 7d550e3 into masterAug 14, 2020
@MorrisJobke
MorrisJobke deleted the enh/apps/use-sidebar branch August 14, 2020 13:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@juliusknorr@jancborchardt@MorrisJobke