Uh oh!
There was an error while loading. Please reload this page.
[stable18] Allow to await the sidebar - #19089
Merged
Merged
Conversation
skjnldsv
requested review from
ChristophWurst, juliusknorr, nickvergessen and rullzerJanuary 23, 2020 07:46
skjnldsv
commented
Jan 23, 2020
MemberAuthor
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
backport/18929/enh/sidebar/promise
branch
from
January 23, 2020 07:49
32dac54 to
db7a0a9Compareskjnldsv
commented
Jan 30, 2020
MemberAuthor
Bump |
Merged
skjnldsv
commented
Feb 4, 2020
MemberAuthor
So, yes, no? :p |
juliusknorr
approved these changes
Feb 4, 2020
ChristophWurst
commented
Feb 4, 2020
Member
#18929 (comment) 🤷♂️ |
Member
I'd say it is not a breaking api change since it basically adds returning a promise, so any previous implementation will continue to work. |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
rullzerforce-pushed
the
backport/18929/enh/sidebar/promise
branch
from
February 5, 2020 19:09
db7a0a9 to
df00000Comparerullzer
commented
Feb 5, 2020
Member
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
backport/18929/enh/sidebar/promise
branch
from
February 5, 2020 19:12
df00000 to
b074be1Comparerullzer
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bacport of #18929