Uh oh!
There was an error while loading. Please reload this page.
Allow to await the sidebar - #18929
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
juliusknorr
approved these changes
Jan 16, 2020
ChristophWurst
approved these changes
Jan 22, 2020
rullzer
commented
Jan 22, 2020
Member
/compile amend / |
npmbuildbot-nextcloudBotforce-pushed
the
enh/sidebar/promise
branch
from
January 22, 2020 08:50
6deb262 to
2a6ae51Comparerullzer
commented
Jan 22, 2020
Member
Needs a rebase! |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
enh/sidebar/promise
branch
from
January 22, 2020 09:43
2a6ae51 to
410e3eeCompareskjnldsv
commented
Jan 22, 2020
MemberAuthor
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloudBotforce-pushed
the
enh/sidebar/promise
branch
from
January 22, 2020 09:46
410e3ee to
2e52bddCompareskjnldsv
commented
Jan 22, 2020
MemberAuthor
@juliushaertl & I approved the backport as this is mostly some code moving around. |
ChristophWurst
commented
Jan 22, 2020
Member
@nickvergessen@rullzer your call. We usually don't backport feature or API changes. |
skjnldsv
commented
Jan 23, 2020
MemberAuthor
/backport to stable18 |
The backport to stable18 failed. Please do this backport manually. |
This was referenced Apr 13, 2020
MorrisJobke added a commit
that referenced
this pull request
Jul 21, 2020
Those tests are actual problems in our code. See #20462 (comment) for a summary by @danxuliu Basically they are introduced by #18929 but are only revealed by #18764. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This was referenced Jul 21, 2020
backportbot-nextcloudBot
pushed a commit
that referenced
this pull request
Jul 21, 2020
Those tests are actual problems in our code. See #20462 (comment) for a summary by @danxuliu Basically they are introduced by #18929 but are only revealed by #18764. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow us to await or use then/catch when requesting a file to the sidebar