Uh oh!
There was an error while loading. Please reload this page.
Give the sharing tab a unique id so it also opens properly on other languages - #19125
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, GretaD, rullzer and skjnldsvJanuary 24, 2020 16:37
juliusknorr
commented
Jan 24, 2020
MemberAuthor
/backport to stable18 |
rullzer
approved these changes
Jan 24, 2020
skjnldsv
commented
Jan 27, 2020
Member
1.2.8 released |
skjnldsv
approved these changes
Jan 27, 2020
rullzer
commented
Jan 27, 2020
Member
@juliushaertl mind to do the rebase dance? |
juliusknorrforce-pushed
the
bugfix/noid/tab-id
branch
from
January 27, 2020 11:59
e4a2e4f to
54233b7Comparejuliusknorr
commented
Jan 27, 2020
MemberAuthor
Done. |
ChristophWurst
approved these changes
Jan 27, 2020
Member
|
This comment has been minimized.
This comment has been minimized.
Merged
skjnldsvforce-pushed
the
bugfix/noid/tab-id
branch
3 times, most recently
from
January 28, 2020 10:04
2bfa82e to
38dbdafCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
skjnldsvforce-pushed
the
bugfix/noid/tab-id
branch
from
January 28, 2020 16:12
38dbdaf to
d819f6aCompare
This comment has been minimized.
This comment has been minimized.
…anguages Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
bugfix/noid/tab-id
branch
from
January 29, 2020 15:45
d819f6a to
b476659Compareskjnldsv
commented
Jan 29, 2020
Member
It seems there is some issue with acceptance tests in master Accept share needs to be disabled as this is enabled by default now, right @rullzer ? Scenario: share a file with another user # /drone/src/tests/acceptance/features/app-files-sharing.feature:383| Given I act as John # ActorContext::iActAs()84| And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()85| And I act as Jane # ActorContext::iActAs()86| And I am logged in # LoginPageContext::iAmLoggedIn()87| And I act as John # ActorContext::iActAs()88| And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()89| And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()90| When I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()91| And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()92| And I act as Jane # ActorContext::iActAs()93| And I accept the share for "farewell.txt" in the notifications # NotificationsContext::iAcceptTheShareForInTheNotifications()94| Notification of incoming share for file farewell.txt could not be found after 350 seconds95| Actions in notification of incoming share for file farewell.txt could not be found after 350 seconds |
skjnldsv
commented
Jan 30, 2020
Member
Yep, tests fails on master as well |
The backport to stable18 failed. Please do this backport manually. |
skjnldsv
commented
Jan 30, 2020
Member
Dam, stable18 is still on old vue components branch xD |
skjnldsv
commented
Jan 30, 2020
Member
Backport in #19212 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Expected: The share tab opens
Actual: The first tab (activity) opens