Skip to content

[stable18] Give the sharing tab a unique id so it also opens properly on other languages - #19212

Merged
rullzer merged 3 commits into
stable18from
backport/19125/bugfix/noid/tab-id
Jan 30, 2020
Merged

[stable18] Give the sharing tab a unique id so it also opens properly on other languages#19212
rullzer merged 3 commits into
stable18from
backport/19125/bugfix/noid/tab-id

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Backport of #19125

juliusknorrand others added 3 commits January 30, 2020 09:41
…anguages
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added bug 3. to review Waiting for reviews feature: file sidebar Related to the file sidebar component labels Jan 30, 2020
@skjnldsvskjnldsv added this to the Nextcloud 18.0.1 milestone Jan 30, 2020
@skjnldsvskjnldsv self-assigned this Jan 30, 2020
@skjnldsvskjnldsv changed the title Give the sharing tab a unique id so it also opens properly on other languages[stable18] Give the sharing tab a unique id so it also opens properly on other languagesJan 30, 2020
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Failures unrelated, they are on stable18 as well https://drone.nextcloud.com/nextcloud/server/25653

@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 30, 2020
@rullzer
rullzer merged commit 297debe into stable18Jan 30, 2020
@rullzer
rullzer deleted the backport/19125/bugfix/noid/tab-id branch January 30, 2020 21:10
@rullzerrullzer mentioned this pull request Feb 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: file sidebarRelated to the file sidebar component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@ChristophWurst@juliusknorr@rullzer