Skip to content

Allow apps to provide Calendars in user's calendarHome - #19196

Merged
rullzer merged 1 commit into
masterfrom
feature/17126/allow_apps_to_register_their_own_calendars
Feb 23, 2020
Merged

Allow apps to provide Calendars in user's calendarHome#19196
rullzer merged 1 commit into
masterfrom
feature/17126/allow_apps_to_register_their_own_calendars

Conversation

@georgehrke

@georgehrkegeorgehrke commented Jan 29, 2020

Copy link
Copy Markdown
Member

@georgehrkegeorgehrke added the 2. developing Work in progress label Jan 29, 2020
@georgehrkegeorgehrke added this to the Nextcloud 19 milestone Jan 29, 2020
@georgehrke
georgehrkeforce-pushed the feature/17126/allow_apps_to_register_their_own_calendars branch from a4ec37a to 47e661cCompareJanuary 30, 2020 10:29
@georgehrkegeorgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 30, 2020
@georgehrke

Copy link
Copy Markdown
MemberAuthor

CI looks good, just some random acceptance tests that failed.

Comment threadapps/dav/lib/AppInfo/PluginManager.php
@georgehrke
georgehrkeforce-pushed the feature/17126/allow_apps_to_register_their_own_calendars branch from 47e661c to 21d8f0fCompareJanuary 31, 2020 20:46

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and works great 👍

Comment threadapps/dav/lib/AppInfo/PluginManager.php
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke
georgehrkeforce-pushed the feature/17126/allow_apps_to_register_their_own_calendars branch from 21d8f0f to b46e5cbCompareFebruary 18, 2020 13:35
@rullzer
rullzer merged commit 713d3d4 into masterFeb 23, 2020
@rullzer
rullzer deleted the feature/17126/allow_apps_to_register_their_own_calendars branch February 23, 2020 16:00
@juliusknorr

juliusknorr commented Feb 23, 2020

Copy link
Copy Markdown
Member

@georgehrke We need an update of the info.xml schema descriptions as well for the new calendar-plugins entry.

@rullzer

Copy link
Copy Markdown
Member

@georgehrke I suggest to do the same for contacts :)

This was referenced Feb 27, 2020
ChristophWurst added a commit that referenced this pull request Mar 30, 2020
For #19795
For #19196
Ref nextcloud/appstore#673
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this pull request Mar 30, 2020
For #19795
For #19196
Ref nextcloud/appstore#673
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow apps to register their own calendars to be exposed in user's calendar home

4 participants

@georgehrke@juliusknorr@rullzer@ChristophWurst