Skip to content

Add address book plugins - #19795

Merged
ChristophWurst merged 2 commits into
masterfrom
enhancement/address-book-plugins
Mar 9, 2020
Merged

Add address book plugins#19795
ChristophWurst merged 2 commits into
masterfrom
enhancement/address-book-plugins

Conversation

@ChristophWurst

@ChristophWurstChristophWurst commented Mar 5, 2020

Copy link
Copy Markdown
Member

Somehow Github refused to reopen #19680, thus a new PR.

Same same as #19196 but different.

  • Pluggable address books
  • Load the address book for the user

Tested with #19075

@ChristophWurstChristophWurst added this to the Nextcloud 19 milestone Mar 5, 2020
@ChristophWurstChristophWurst self-assigned this Mar 5, 2020
@ChristophWurstChristophWurst mentioned this pull request Mar 5, 2020
Merged
juliusknorr
juliusknorr reviewed Mar 9, 2020
View reviewed changes
Comment threadapps/dav/lib/CardDAV/AddressBookRoot.php
@ChristophWurst
Add address book plugins
ec245d5
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
ChristophWurstforce-pushed the enhancement/address-book-plugins branch from 9c302de to ec245d5CompareMarch 9, 2020 12:12
juliusknorr
juliusknorr approved these changes Mar 9, 2020
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise and seems to do the trick with the parts already available in #19075

georgehrke
georgehrke requested changes Mar 9, 2020
View reviewed changes

@georgehrkegeorgehrke left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UserAddressbooks should check for reserved names when creating a new collection.
Similar to here: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CalDAV/CalendarHome.php#L76L84

@ChristophWurst
Prevent creation of reserved address book name
827c098
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst

ChristophWurst commented Mar 9, 2020

Copy link
Copy Markdown
MemberAuthor

Thanks @georgehrke. Added the check :)

rullzer
rullzer approved these changes Mar 9, 2020
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do extensive testing. But code looks sane

@ChristophWurst

ChristophWurst commented Mar 9, 2020

Copy link
Copy Markdown
MemberAuthor

@georgehrke ok to merge this? :)

georgehrke
georgehrke approved these changes Mar 9, 2020
View reviewed changes

@georgehrkegeorgehrke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristophWurst
ChristophWurst merged commit 5b0dfd3 into masterMar 9, 2020
@ChristophWurst
ChristophWurst deleted the enhancement/address-book-plugins branch March 9, 2020 16:32
@blizzz

blizzz commented Mar 26, 2020

Copy link
Copy Markdown
Member

@ChristophWurst the extension of info.xml has to be defined in https://github.com/nextcloud/appstore/blob/master/nextcloudappstore/api/v1/release/info.xsd

@juliusknorr

juliusknorr commented Mar 29, 2020

Copy link
Copy Markdown
Member

And https://github.com/nextcloud/server/blob/master/resources/app-info-shipped.xsd / https://github.com/nextcloud/server/blob/master/resources/app-info.xsd 😉

@ChristophWurst

ChristophWurst commented Mar 30, 2020

Copy link
Copy Markdown
MemberAuthor

👍 I'll also add it for #19196 while at it

@ChristophWurstChristophWurst mentioned this pull request Mar 30, 2020
Merged
ChristophWurst added a commit that referenced this pull request Mar 30, 2020
@ChristophWurst
Update the info.xsd for address book and calendar plugins
72ad998
For #19795
For #19196
Ref nextcloud/appstore#673
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this pull request Mar 30, 2020
@ChristophWurst
Update the info.xsd for address book and calendar plugins
8d9536e
For #19795
For #19196
Ref nextcloud/appstore#673
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurstChristophWurst mentioned this pull request Mar 30, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@georgehrkegeorgehrkegeorgehrke approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@kesselbkesselbAwaiting requested review from kesselb

Assignees

@ChristophWurstChristophWurst

Labels

3. to reviewWaiting for reviewsenhancementfeature: davintegration

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@blizzz@juliusknorr@rullzer@georgehrke