Skip to content

Add option to check share ACL's when listing directories - #19399

Merged
blizzz merged 2 commits into
masterfrom
smb-read-acl
Apr 22, 2020
Merged

Add option to check share ACL's when listing directories#19399
blizzz merged 2 commits into
masterfrom
smb-read-acl

Conversation

@icewind1991

@icewind1991icewind1991 commented Feb 10, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 10, 2020
@icewind1991icewind1991 added this to the Nextcloud 19 milestone Feb 10, 2020
@icewind1991icewind1991 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 10, 2020
@Gogowitsch

Gogowitsch commented Mar 14, 2020

Copy link
Copy Markdown

  1. I suggest to split this into topical commits. For example, I would prefer one for composer-related changes.

  2. Can you describe in more detail which install scenario and use case this PR solves? Thanks!

@icewind1991icewind1991 changed the title dont show smb file/folder if read permissions is denied by aclAdd option to check share ACL's when listing directoriesApr 2, 2020
@icewind1991icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 2, 2020
@icewind1991icewind1991 mentioned this pull request Apr 2, 2020
Merged
This was referenced Apr 4, 2020
Merged
Merged
skjnldsv
skjnldsv reviewed Apr 10, 2020
View reviewed changes
Comment threadapps/files_external/lib/Lib/Storage/SMB.php Outdated
skjnldsv
skjnldsv approved these changes Apr 10, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts 💥

This was referenced Apr 15, 2020
Merged
Merged
@icewind1991

icewind1991 commented Apr 16, 2020

Copy link
Copy Markdown
MemberAuthor

rebased, unit tests are happy

@icewind1991
Add option to check share ACL's when listing directories
23e2bae
If a file or folder in a directory doesn't have read permissions they
will not be shown
Note that enabling this option incurs a performance penalty additional
requests need to be made to get all the acl.
Additionally the acl resolving logic is fairly primitive at the moment
and might not work correctly in all setups (it should error to showing
the entry)
Signed-off-by: Robin Appelman <robin@icewind.nl>
juliusknorr
juliusknorr approved these changes Apr 21, 2020
View reviewed changes

@juliusknorrjuliusknorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me 👍

@juliusknorr

juliusknorr commented Apr 21, 2020

Copy link
Copy Markdown
Member

Failing php-cs check 😉

@icewind1991
add tooltip to option
7f32fe6
Signed-off-by: Robin Appelman <robin@icewind.nl>
@blizzz
blizzz merged commit 4a8871f into masterApr 22, 2020
@blizzz
blizzz deleted the smb-read-acl branch April 22, 2020 21:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

5 participants

@icewind1991@Gogowitsch@juliusknorr@skjnldsv@blizzz