Skip to content

allow setting tooltips for external storage config options - #20276

Merged
rullzer merged 1 commit into
masterfrom
files-external-param-tooltop
Apr 6, 2020
Merged

allow setting tooltips for external storage config options#20276
rullzer merged 1 commit into
masterfrom
files-external-param-tooltop

Conversation

@icewind1991

Copy link
Copy Markdown
Member

allows explaining non-obvious config options a bit more

Would like to add a tooltip to the option from #19399

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Apr 2, 2020
@icewind1991icewind1991 added this to the Nextcloud 19 milestone Apr 2, 2020

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

@rullzer

Copy link
Copy Markdown
Member

@rullzerrullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 3, 2020
allows explaining non-obvious config options a bit more
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the files-external-param-tooltop branch from cb48e19 to 857957bCompareApril 3, 2020 13:45
@icewind1991

Copy link
Copy Markdown
MemberAuthor

fixed the files_external tests

@rullzerrullzer mentioned this pull request Apr 4, 2020
80 tasks
@rullzer
rullzer merged commit 1d62b97 into masterApr 6, 2020
@rullzer
rullzer deleted the files-external-param-tooltop branch April 6, 2020 14:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@rullzer@juliusknorr@skjnldsv