Skip to content

disable timeout on app install via cli - #19430

Merged
blizzz merged 1 commit into
masterfrom
fix/17808/remove-timeout-appinstall
Feb 12, 2020
Merged

disable timeout on app install via cli#19430
blizzz merged 1 commit into
masterfrom
fix/17808/remove-timeout-appinstall

Conversation

@blizzz

@blizzzblizzz commented Feb 12, 2020

Copy link
Copy Markdown
Member

this helps at least with installation/updating of big apps via CLI. Web UI is a different story, still.

@blizzzblizzz added this to the Nextcloud 19 milestone Feb 12, 2020
@blizzz

blizzz commented Feb 12, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@blizzz

blizzz commented Feb 12, 2020

Copy link
Copy Markdown
MemberAuthor

related issues: #17808#17776nextcloud/documentserver_community#26 (they are also all web ui related)

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 12, 2020
@nickvergessen

nickvergessen commented Feb 12, 2020

Copy link
Copy Markdown
Member

Well most of the issues suggest a value of 120, which we now have in 18.0.1 it was jsut not released yet

@blizzz

blizzz commented Feb 12, 2020

Copy link
Copy Markdown
MemberAuthor

Well most of the issues suggest a value of 120, which we now have in 18.0.1 it was jsut not released yet

curl -Lm 0 --output /dev/null https://github.com/nextcloud/documentserver_community/releases/download/v0.1.5/documentserver_community.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 622 0 622 0 0 1026 0 --:--:-- --:--:-- --:--:-- 1026
100 301M 100 301M 0 0 2324k 0 0:02:12 0:02:12 --:--:-- 2994k

@nickvergessen

nickvergessen commented Feb 12, 2020

Copy link
Copy Markdown
Member

Yeah sure, just be aware people will still run into this from the web, but well don't care, continue

@blizzz

blizzz commented Feb 12, 2020

Copy link
Copy Markdown
MemberAuthor

Yeah sure, just be aware people will still run into this from the web, but well don't care, continue

Yes, I discussed it with @rullzer earlier today, and agreed on doing the CLI change for now only.

@rullzer

rullzer commented Feb 12, 2020

Copy link
Copy Markdown
Member

Yeah from the CLI I'm fine. Poeple can then easily cancel it anyways.

@blizzz
disable timeout on app install via cli
d06ef07
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the fix/17808/remove-timeout-appinstall branch from 0a66b43 to d06ef07CompareFebruary 12, 2020 15:53
@blizzz
blizzz merged commit 6bf0c1f into masterFeb 12, 2020
@blizzz
blizzz deleted the fix/17808/remove-timeout-appinstall branch February 12, 2020 16:34
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Feb 12, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Feb 12, 2020

Copy link
Copy Markdown

backport to stable18 in #19439

@nickvergessennickvergessen mentioned this pull request Feb 17, 2020
Merged
@kesselbkesselb mentioned this pull request Mar 3, 2020
Closed
@ftoralftoral mentioned this pull request Mar 31, 2020
Closed
@szaimenszaimen mentioned this pull request Jun 22, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@kesselbkesselbkesselb approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: apps managementfeature: occ

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

6 participants

@blizzz@nickvergessen@rullzer@icewind1991@ChristophWurst@kesselb