Skip to content

Catch NotFoundException when getting the user folder - #19655

Merged
rullzer merged 1 commit into
masterfrom
bugfix/noid/upload-cleanup-user-not-found
Feb 28, 2020
Merged

Catch NotFoundException when getting the user folder#19655
rullzer merged 1 commit into
masterfrom
bugfix/noid/upload-cleanup-user-not-found

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Feb 26, 2020

Copy link
Copy Markdown
Member

There might be cases where the job is scheduled and the user data is removed between scheduling and actually running the job, so we should catch the NotFoundException here as well, as it is done in

server/apps/dav/lib/Migration/ChunkCleanup.php

Line 75 in 5bf3d1b

$userFolder = $this->rootFolder->getUserFolder($user->getUID());

@juliusknorr
Catch NotFoundException when getting the user folder
4b593cb
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews labels Feb 26, 2020
@juliusknorrjuliusknorr added this to the Nextcloud 19 milestone Feb 26, 2020
ChristophWurst
ChristophWurst approved these changes Feb 26, 2020
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2020
@rullzer
rullzer merged commit e231dd8 into masterFeb 28, 2020
@rullzer
rullzer deleted the bugfix/noid/upload-cleanup-user-not-found branch February 28, 2020 07:51
@juliusknorrjuliusknorr mentioned this pull request Apr 3, 2020
Merged
@juliusknorr

juliusknorr commented Apr 6, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@juliusknorr

juliusknorr commented Apr 6, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@juliusknorr

juliusknorr commented Apr 6, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable16

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 6, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 6, 2020

Copy link
Copy Markdown

backport to stable18 in #20335

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 6, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 6, 2020

Copy link
Copy Markdown

backport to stable17 in #20336

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Apr 6, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Apr 6, 2020

Copy link
Copy Markdown

backport to stable16 in #20337

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@blizzzblizzzblizzz approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

5 participants

@juliusknorr@nickvergessen@ChristophWurst@blizzz@rullzer