Uh oh!
There was an error while loading. Please reload this page.
Properly catch NoUserException during upload cleanup - #20284
Merged
Conversation
juliusknorr
requested review from
ChristophWurst, icewind1991, kesselb and rullzerApril 3, 2020 10:21
| @@ -66,6 +67,9 @@ protected function run($argument) { | |||
| } catch (NotFoundException $e) { | |||
There was a problem hiding this comment.
Suggested change
| } catch (NotFoundException $e) { | |
| } catch (NotFoundException|NoUserException$e) { |
Does the same, without the duplication :)
ChristophWurst
approved these changes
Apr 3, 2020
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Despite my nitpick this looks good :)
ChristophWurst
approved these changes
Apr 3, 2020
rullzer
approved these changes
Apr 3, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorrforce-pushed
the
bugfix/noid/catch-no-user-in-cron
branch
from
April 3, 2020 21:06
d424e0c to
56aa8fdComparejuliusknorr
commented
Apr 6, 2020
MemberAuthor
/backport to stable18 |
juliusknorr
commented
Apr 6, 2020
MemberAuthor
/backport to stable17 |
juliusknorr
commented
Apr 6, 2020
MemberAuthor
/backport to stable16 |
backport to stable18 in #20334 |
The backport to stable17 failed. Please do this backport manually. |
The backport to stable16 failed. Please do this backport manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #19655
getUserFoldermight throw aNoUserExceptionif the job was scheduled before the user removal. This would cause the background job to never succee and causingBackends provided no user objecterrors.The second commit adds proper annotations for the exceptions being thrown by
getUserFolder.