Allow some apps to have root URLs in their own routing file by nickvergessen · Pull Request #20114 · nextcloud/server

nickvergessen · 2020-03-23T15:47:35Z

Follow up to prevent #20038 from spreading

nickvergessen · 2020-03-23T15:49:05Z

- ['name' => 'requesthandlercontroller#addShare', 'url' => '/ocm/shares', 'verb' => 'POST', 'app' => 'cloud_federation_api'],
- ['name' => 'requesthandlercontroller#receiveNotification', 'url' => '/ocm/notifications', 'verb' => 'POST', 'app' => 'cloud_federation_api'],
- ['name' => 'pagecontroller#showCall', 'url' => '/call/{token}', 'verb' => 'GET', 'app' => 'spreed'],
- ['name' => 'pagecontroller#authenticatePassword', 'url' => '/call/{token}', 'verb' => 'POST', 'app' => 'spreed'],


Those are now in nextcloud/spreed#3134
All other apps are in this PR

nickvergessen · 2020-03-23T15:49:47Z

 	private function processOCS(array $routes): void {
 $ocsRoutes = $routes['ocs'] ?? [];
 foreach ($ocsRoutes as $ocsRoute) {
- $name = $ocsRoute['name'];


Best review this file on https://github.com/nextcloud/server/pull/20114/files?w=1

skjnldsv · 2020-04-11T07:27:16Z

Rebased

skjnldsv · 2020-04-11T07:33:20Z

Lots of failures

danxuliu

PHP CS is not happy.

Some integration and acceptance tests failures are legit, and all seem to be caused by Unable to generate a URL for the named route \"cloud_federation_api.RequestHandler.addShare\" as such route does not exist.

nickvergessen · 2020-04-17T07:58:06Z

PHP CS is not happy.

Should be fixed by a last rebase as it's not caused by this PR.

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen · 2020-04-21T12:45:01Z

SHould be good to go now?
Not sure what the acceptance tests complain about. And the failing integration tests are caused by #16035

rullzer · 2020-04-21T14:00:27Z

SHould be good to go now?
Not sure what the acceptance tests complain about. And the failing integration tests are caused by #16035

Lets do this and we fix stuff if it does boom

danxuliu · 2020-04-21T18:38:29Z

Not sure what the acceptance tests complain about

The app-comments can be ignored, they are caused by a regression in the sidebar. The others are legit; for some reason with this pull request the Apps app and the Users app show a blank page (and in 8f650fe^ they work fine).

rullzer · 2020-04-21T20:14:03Z

Not sure what the acceptance tests complain about
The app-comments can be ignored, they are caused by a regression in the sidebar. The others are legit; for some reason with this pull request the Apps app and the Users app show a blank page (and in 8f650fe^ they work fine).

which apps?

rullzer · 2020-04-21T20:42:56Z

aah the apps and user page
mmm indeed.... so I ahve a crude fix ut this seems to break js...

No longer needed from what I can tell since #20114 & nextcloud/spreed#3134 Signed-off-by: Josh <josh.t.richards@gmail.com>

nickvergessen added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 23, 2020

nickvergessen added this to the Nextcloud 19 milestone Mar 23, 2020

nickvergessen requested a review from rullzer March 23, 2020 15:47

nickvergessen mentioned this pull request Mar 23, 2020
Move routes to app nextcloud/spreed#3134
Merged
2 tasks

nickvergessen commented Mar 23, 2020
View reviewed changes

ChristophWurst approved these changes Mar 24, 2020
View reviewed changes

This was referenced Apr 4, 2020
19 beta 2 #20303
Merged
19 beta 3 #20386
Merged

rullzer approved these changes Apr 9, 2020
View reviewed changes

skjnldsv force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from 90dda67 to 12c43b3Compare April 11, 2020 06:42

skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 11, 2020

nickvergessen force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from 12c43b3 to e07f126Compare April 14, 2020 15:26

nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Apr 14, 2020

nickvergessen mentioned this pull request Apr 14, 2020
Ignore unavailable app on foreign route call #20038
Closed

skjnldsv force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from d7058c6 to 8e786e4Compare April 15, 2020 06:00

nickvergessen force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from 8e786e4 to 4bae8dbCompare April 15, 2020 12:13

This was referenced Apr 15, 2020
19 beta 4 #20506
Merged
19 Beta 5 #20510
Merged

danxuliu requested changes Apr 16, 2020
View reviewed changes

nickvergessen force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from 4bae8db to a0f75aeCompare April 17, 2020 09:21

nickvergessen added 3 commits April 18, 2020 11:21

Allow some apps to have root URLs in their own routing file
3f8168b
Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix creation of legacy routes
aad16c8
Signed-off-by: Joas Schilling <coding@schilljs.com>

PHP CS fixes
f93d55e
Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen added 8 commits April 18, 2020 11:21

Extend tests for root url
250467e
Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix legacy routes
708b499
Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix creating the share controller
e45c87c
Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix route definitions of cloud_federation_api
9654a92
Signed-off-by: Joas Schilling <coding@schilljs.com>

Reduce noise in test output
031b665
Signed-off-by: Joas Schilling <coding@schilljs.com>

Make sure the cloud_federation_api routes are loaded
6332d7c
Signed-off-by: Joas Schilling <coding@schilljs.com>

Directly use the class to get the service
685d7b0
Signed-off-by: Joas Schilling <coding@schilljs.com>

PHP CS fixes
1b93d5f
Signed-off-by: Joas Schilling <coding@schilljs.com>

rullzer force-pushed the techdebt/noid/allow-some-apps-to-have-root-urls branch from ebba033 to 1b93d5fCompare April 18, 2020 09:21

rullzer merged commit 8f650fe into masterApr 21, 2020

rullzer deleted the techdebt/noid/allow-some-apps-to-have-root-urls branch April 21, 2020 14:00

rullzer mentioned this pull request Apr 21, 2020
Fix settings routing #20591
Merged

NeutroGe mentioned this pull request May 27, 2020
Cannot declare class OCA\Talk\Migration\Version2000Date20170707093535 nextcloud/spreed#2806
Closed

joshtrichards added a commit that referenced this pull request Aug 4, 2025
refactor(AppFramework): drop unused spreed/Talk fallback
9195987
No longer needed from what I can tell since #20114 & nextcloud/spreed#3134 Signed-off-by: Josh <josh.t.richards@gmail.com>

joshtrichards mentioned this pull request Aug 4, 2025
refactor(AppFramework): drop unused spreed/Talk fallback #54239
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

Allow some apps to have root URLs in their own routing file - #20114

Allow some apps to have root URLs in their own routing file#20114
rullzer merged 11 commits into
masterfrom
techdebt/noid/allow-some-apps-to-have-root-urls

nickvergessen commented Mar 23, 2020

Uh oh!

nickvergessenMar 23, 2020

Uh oh!

nickvergessenMar 23, 2020

Uh oh!

skjnldsv commented Apr 11, 2020

Uh oh!

skjnldsv commented Apr 11, 2020

Uh oh!

danxuliu left a comment

Uh oh!

nickvergessen commented Apr 17, 2020

Uh oh!

nickvergessen commented Apr 21, 2020

Uh oh!

rullzer commented Apr 21, 2020

Uh oh!

danxuliu commented Apr 21, 2020

Uh oh!

rullzer commented Apr 21, 2020

Uh oh!

rullzer commented Apr 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

nickvergessen commented Mar 23, 2020

Uh oh!

nickvergessenMar 23, 2020

Choose a reason for hiding this comment

Uh oh!

nickvergessenMar 23, 2020

Choose a reason for hiding this comment

Uh oh!

skjnldsv commented Apr 11, 2020

Uh oh!

skjnldsv commented Apr 11, 2020

Uh oh!

danxuliu left a comment

Choose a reason for hiding this comment

Uh oh!

nickvergessen commented Apr 17, 2020

Uh oh!

nickvergessen commented Apr 21, 2020

Uh oh!

rullzer commented Apr 21, 2020

Uh oh!

danxuliu commented Apr 21, 2020

Uh oh!

rullzer commented Apr 21, 2020

Uh oh!

rullzer commented Apr 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants