Skip to content

refactor(AppFramework): drop unused spreed/Talk fallback - #54239

Merged
joshtrichards merged 1 commit into
masterfrom
cleanup-appframework-spreed
Aug 5, 2025
Merged

refactor(AppFramework): drop unused spreed/Talk fallback#54239
joshtrichards merged 1 commit into
masterfrom
cleanup-appframework-spreed

Conversation

@joshtrichards

Copy link
Copy Markdown
Member

Summary

No longer needed from what I can tell since #20114 & nextcloud/spreed#3134

TODO

Checklist

No longer needed from what I can tell since #20114 & nextcloud/spreed#3134
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
joshtrichards requested a review from a team as a code ownerAugust 4, 2025 13:01
@joshtrichardsjoshtrichards added the 3. to review Waiting for reviews label Aug 4, 2025
@joshtrichards
joshtrichards requested review from CarlSchwan and icewind1991 and removed request for a teamAugust 4, 2025 13:01
@joshtrichardsjoshtrichards added integration ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Aug 4, 2025
@joshtrichardsjoshtrichards added this to the Nextcloud 32 milestone Aug 4, 2025
nickvergessen added a commit to nextcloud/spreed that referenced this pull request Aug 5, 2025
@nickvergessen

Copy link
Copy Markdown
Member

@nickvergessennickvergessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests seem to pass, so fine by me

@nickvergessen
nickvergessen requested review from miaulalala and removed request for CarlSchwan, danxuliu, icewind1991 and sorbaughAugust 5, 2025 11:15
@joshtrichards
joshtrichards merged commit 2aa6894 into masterAug 5, 2025
196 checks passed
@joshtrichards
joshtrichards deleted the cleanup-appframework-spreed branch August 5, 2025 12:42
@skjnldsvskjnldsv mentioned this pull request Aug 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: apps managementintegration♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joshtrichards@nickvergessen@come-nc@skjnldsv