Skip to content

Fix share expiration date not shown - #20538

Merged
rullzer merged 1 commit into
masterfrom
fix/20520/share-expire
Apr 30, 2020
Merged

Fix share expiration date not shown#20538
rullzer merged 1 commit into
masterfrom
fix/20520/share-expire

Conversation

@gary-kim

@gary-kimgary-kim commented Apr 17, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#20520

Needs to be built with nextcloud-libraries/nextcloud-vue#1029 No longer necessary.

Signed-off-by: Gary Kim gary@garykim.dev

@gary-kimgary-kim added bug 3. to review Waiting for reviews labels Apr 17, 2020
@gary-kimgary-kim added this to the Nextcloud 19 milestone Apr 17, 2020
gary-kim
gary-kim commented Apr 17, 2020
View reviewed changes
Comment threadapps/files_sharing/src/mixins/SharesMixin.js Outdated
@gary-kim
gary-kimforce-pushed the fix/20520/share-expire branch from 7f363db to dc436abCompareApril 17, 2020 14:17
skjnldsv
skjnldsv approved these changes Apr 17, 2020
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good :D

@gary-kim
gary-kimforce-pushed the fix/20520/share-expire branch from dc436ab to 728781eCompareApril 17, 2020 15:49
@gary-kim

gary-kim commented Apr 17, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

There's also a seperate issue where the not-before and not-after don't do anything in vue2-datepicker. It wants a disabled-date function instead. Should we implement that in @nextcloud/vue so other apps can reuse it or here?

@skjnldsv

skjnldsv commented Apr 17, 2020

Copy link
Copy Markdown
Member

There's also a seperate issue where the not-before and not-after don't do anything in vue2-datepicker. It wants a disabled-date function instead. Should we implement that in @nextcloud/vue so other apps can reuse it or here?

I guess we should adapt this here :)
We shouldn't be more complicated than the original library. W''re just wrapping our styling mostly :)

So let's upgrade to disabled-date here ?

@rullzerrullzer mentioned this pull request Apr 18, 2020
Merged
55 tasks
@skjnldsvskjnldsv mentioned this pull request Apr 22, 2020
Merged
@rullzerrullzer mentioned this pull request Apr 23, 2020
Merged
11 tasks
@ChristophWurst

ChristophWurst commented Apr 30, 2020

Copy link
Copy Markdown
Member

So let's upgrade to disabled-date here ?

@gary-kim@skjnldsv is this ok to merge or are there any missing changes?

@gary-kim

gary-kim commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

So let's upgrade to disabled-date here ?

@gary-kim@skjnldsv is this ok to merge or are there any missing changes?

I'd say that's a separate issue that's better addressed in another PR.

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 30, 2020
@skjnldsv

skjnldsv commented Apr 30, 2020

Copy link
Copy Markdown
Member

Please rebase :)

@gary-kim
gary-kimforce-pushed the fix/20520/share-expire branch from 728781e to 8c71659CompareApril 30, 2020 08:10
@gary-kim

gary-kim commented Apr 30, 2020

Copy link
Copy Markdown
MemberAuthor

Please rebase :)

Done!

@gary-kim
Fix share expiration date not shown
02b5ded
Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim
gary-kimforce-pushed the fix/20520/share-expire branch from 8c71659 to 02b5dedCompareApril 30, 2020 14:36
@rullzerrullzer mentioned this pull request Apr 30, 2020
Merged
2 tasks
@rullzer
rullzer merged commit b2b8be8 into masterApr 30, 2020
@rullzer
rullzer deleted the fix/20520/share-expire branch April 30, 2020 18:55
@gary-kimgary-kim mentioned this pull request May 1, 2020
Merged
@skjnldsv

skjnldsv commented May 1, 2020

Copy link
Copy Markdown
Member

Wait, this actually broke things 🙈
value-type="format" means they'll use the data provided by "format".
But we don't provide any format 🤷

@skjnldsv

skjnldsv commented May 1, 2020

Copy link
Copy Markdown
Member

AH it's fine, format has default 'YYYY-MM-DD'
Let me see what broke then, might not be this pr

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 19

Development

Successfully merging this pull request may close these issues.

Share expiration date not shown

4 participants

@gary-kim@skjnldsv@ChristophWurst@rullzer