Skip to content

Fix expiry datepicker allowing all dates - #20762

Merged
rullzer merged 1 commit into
masterfrom
fix/20538/date-not-disabled
May 2, 2020
Merged

Fix expiry datepicker allowing all dates#20762
rullzer merged 1 commit into
masterfrom
fix/20538/date-not-disabled

Conversation

@gary-kim

@gary-kimgary-kim commented May 1, 2020

Copy link
Copy Markdown
Member

vue2-datepicker expects a disabled-date function
rather than not-before and not-after dates.

This commit updates it so that we now provide
vue2-datepicker with a disabled-date function.

Follow up to #20538

Signed-off-by: Gary Kim gary@garykim.dev

@gary-kimgary-kim added bug 3. to review Waiting for reviews labels May 1, 2020
@gary-kimgary-kim added this to the Nextcloud 19 milestone May 1, 2020
@rullzerrullzer mentioned this pull request May 1, 2020
2 tasks
Comment threadapps/files_sharing/src/components/SharingEntry.vue Outdated
Comment threadapps/files_sharing/src/mixins/SharesMixin.js Outdated
@gary-kim
gary-kimforce-pushed the fix/20538/date-not-disabled branch from b468eac to 09c5dd5CompareMay 1, 2020 16:30
Comment threadapps/files_sharing/src/components/SharingEntry.vue Outdated
@gary-kim
gary-kimforce-pushed the fix/20538/date-not-disabled branch 2 times, most recently from 5e02023 to f1b1e23CompareMay 2, 2020 05:57
Comment threadapps/files_sharing/src/mixins/SharesMixin.js Outdated
@gary-kim
gary-kimforce-pushed the fix/20538/date-not-disabled branch from f1b1e23 to 4ecb1f4CompareMay 2, 2020 08:58
Comment threadapps/files_sharing/src/mixins/SharesMixin.js Outdated
Comment threadapps/files_sharing/src/mixins/SharesMixin.js Outdated
vue2-datepicker expects a `disabled-date` function
rather than `not-before` and `not-after` dates.
This commit updates it so that we now provide
vue2-datepicker with a `disabled-date` function.
Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim
gary-kimforce-pushed the fix/20538/date-not-disabled branch from 4ecb1f4 to 8dd23f9CompareMay 2, 2020 10:59
@rullzer
rullzer merged commit 8910a1f into masterMay 2, 2020
@rullzer
rullzer deleted the fix/20538/date-not-disabled branch May 2, 2020 12:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@gary-kim@rullzer@skjnldsv