Uh oh!
There was an error while loading. Please reload this page.
[stable18] Use the correct mountpoint to calculate - #21773
Merged
Conversation
If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloudBot
requested review from
ChristophWurst, danxuliu, juliusknorr, nickvergessen and rullzerJuly 9, 2020 12:33
rullzer
approved these changes
Jul 9, 2020
danxuliu
reviewed
Jul 9, 2020
danxuliu
left a comment
Member
There was a problem hiding this comment.
There is a failed unit test (SharedMountTest::testPermissionMovedGroupShare), but I do not know if it is related.
rullzer
commented
Jul 9, 2020
Member
I don't think it is related. But I restarted jsutin case. Esp since it was only on 1 of the runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #21489