Uh oh!
There was an error while loading. Please reload this page.
Use the correct mountpoint to calculate - #21489
Merged
Merged
Conversation
rullzer
requested review from
ChristophWurst, danxuliu, juliusknorr and nickvergessenJune 19, 2020 14:28
ChristophWurst
approved these changes
Jun 23, 2020
danxuliu
requested changes
Jun 23, 2020
| $userMountPoint = array_shift($userMountPoints); | ||
| if ($userMountPoint === null) { | ||
| throw new \Exception('Could not get proper user mount for ' . $userMountPointId . '. Failing since else the next calls are called with null'); |
Member
There was a problem hiding this comment.
This should be a GenericShareException, or it should be documented that generalCreateChecks can throw a plain Exception too.
nickvergessen
commented
Jun 29, 2020
Member
Looking into the tests now |
nickvergessen
commented
Jun 29, 2020
Member
Tried my best but this is so … up. |
rullzerforce-pushed
the
fix/share/use_correct_mount
branch
from
July 9, 2020 07:01
071603f to
25c4591CompareIf we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
rullzerforce-pushed
the
fix/share/use_correct_mount
branch
from
July 9, 2020 09:15
25c4591 to
118965aComparenickvergessen
commented
Jul 9, 2020
Member
Backports I guess @rullzer |
rullzer
commented
Jul 9, 2020
MemberAuthor
Yes |
rullzer
commented
Jul 9, 2020
MemberAuthor
/backport to stable19 |
rullzer
commented
Jul 9, 2020
MemberAuthor
/backport to stable18 |
rullzer
commented
Jul 9, 2020
MemberAuthor
/backport to stable17 |
This was referenced Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl