Uh oh!
There was an error while loading. Please reload this page.
[stable17] Use the correct mountpoint to calculate - #21774
Merged
Conversation
If we use the owners mount point this results in null. And then the rest of the checks get called with null. Which doesn't work. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
backportbot-nextcloudBot
requested review from
ChristophWurst, danxuliu, juliusknorr, nickvergessen and rullzerJuly 9, 2020 12:33
rullzer
approved these changes
Jul 9, 2020
danxuliu
requested changes
Jul 9, 2020
danxuliu
left a comment
Member
There was a problem hiding this comment.
The integration tests need to be adjusted for stable17, as they use an undefined step. I will take care of it later.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
danxuliuforce-pushed
the
backport/21489/stable17
branch
from
July 9, 2020 18:21
c3673d8 to
50f49c2Comparedanxuliu
approved these changes
Jul 9, 2020
danxuliu
left a comment
Member
There was a problem hiding this comment.
Done, it was just a matter of removing the accepting last share steps, as they were introduced in Nextcloud 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport of #21489