Revert "Disable fragile comments tests"

[MorrisJobke]

This reverts commit c25c984.

Revert of #21934

Those tests are actual problems in our code. See #20462 (comment) for a summary by @danxuliu

Basically they are introduced by #18929 but are only revealed by #18764.

cc @skjnldsv@juliushaertl@danxuliu

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 30946: failure

acceptance-app-comments

• /drone/src/tests/acceptance/features/app-comments.feature:21
• /drone/src/tests/acceptance/features/app-comments.feature:126
• /drone/src/tests/acceptance/features/app-comments.feature:233
• /drone/src/tests/acceptance/features/app-comments.feature:288
• /drone/src/tests/acceptance/features/app-comments.feature:308

Show full log

 Scenario: write a comment in a file right after writing a comment in another file # /drone/src/tests/acceptance/features/app-comments.feature:21
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Comment in Folder" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Comment in Folder" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Comment in Folder" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the details view for "welcome.txt" # FileListContext::iOpenTheDetailsViewFor()
When I create a new comment with "Comment in welcome.txt" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
Then I see a comment with "Comment in welcome.txt" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that there is no comment with "Comment in Folder" as message # CommentsAppContext::iSeeThatThereIsNoCommentWithAsMessage()
Scenario: unread comment icon shown for comment written by the sharer in a shared folder # /drone/src/tests/acceptance/features/app-comments.feature:126
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I share "Folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that "Folder" has unread comments # FileListContext::iSeeThatHasUnreadComments()
And I open the unread comments for "Folder" # FileListContext::iOpenTheUnreadCommentsFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Scenario: search a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:233
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
Then I see that the search result 1 is "user0Hello world" # SearchContext::iSeeThatTheSearchResultIs()
And I see that the search result 1 was found in "Folder/Child folder" # SearchContext::iSeeThatTheSearchResultWasFoundIn()
Scenario: open a search result for a comment in a folder named like its child folder # /drone/src/tests/acceptance/features/app-comments.feature:288
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I see that the file list contains a file named "Folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Scenario: open a search result for a comment in a child folder # /drone/src/tests/acceptance/features/app-comments.feature:308
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "Folder" # FileListContext::iCreateANewFolderNamed()
And I enter in the folder named "Folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Child folder" # FileListContext::iCreateANewFolderNamed()
And I open the details view for "Child folder" # FileListContext::iOpenTheDetailsViewFor()
And I open the "Comments" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I create a new comment with "Hello world" as message # CommentsAppContext::iCreateANewCommentWithAsMessage()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
Details view in Files app could not be found after 100 seconds
Comment list in details view in Files app could not be found after 100 seconds
Comment with text "Hello world" in details view in Files app could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
When I search for "hello" # SearchContext::iSearchFor()
And I open the search result 1 # SearchContext::iOpenTheSearchResult()
Then I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I see that the file name shown in the details view is "Child folder" # FilesAppContext::iSeeThatTheFileNameShownInTheDetailsViewIs()
And I see a comment with "Hello world" as message # CommentsAppContext::iSeeACommentWithAsMessage()
And I see that the file list is currently in "Home/Folder" # FileListContext::iSeeThatTheFileListIsCurrentlyIn()
And I see that the file list contains a file named "Child folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()