Skip to content

Implement Contacts Backend for Unified Search - #22011

Merged
skjnldsv merged 1 commit into
masterfrom
feature/20919/contacts_search
Aug 3, 2020
Merged

Implement Contacts Backend for Unified Search#22011
skjnldsv merged 1 commit into
masterfrom
feature/20919/contacts_search

Conversation

@georgehrke

Copy link
Copy Markdown
Member

fixes#20919

requires #21971

@georgehrkegeorgehrke added the 2. developing Work in progress label Jul 27, 2020
Comment threadapps/dav/lib/Search/ContactsSearchProvider.php Outdated
Comment threadapps/dav/lib/Search/ContactsSearchProvider.php
Comment threadapps/dav/lib/CardDAV/CardDavBackend.php Outdated
@georgehrkegeorgehrke added this to the Nextcloud 20 milestone Jul 29, 2020
@georgehrke
georgehrkeforce-pushed the feature/20919/contacts_search branch from 39d98cd to 7ee97f5CompareJuly 30, 2020 13:46
@georgehrke

Copy link
Copy Markdown
MemberAuthor

@skjnldsv Can i hand this PR over to you?
It's done except for the deep linking to the Contacts app, which requires a new route.

@georgehrke
georgehrkeforce-pushed the feature/20919/contacts_search branch from 7ee97f5 to 6887d48CompareJuly 30, 2020 13:50
@skjnldsv

Copy link
Copy Markdown
Member

Awesome thanks :)

@skjnldsvskjnldsv self-assigned this Jul 30, 2020
@skjnldsv
skjnldsvforce-pushed the feature/20919/contacts_search branch from 7357ef4 to 29fbfa9CompareAugust 3, 2020 09:41
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 3, 2020
@skjnldsv
skjnldsvforce-pushed the feature/20919/contacts_search branch 2 times, most recently from 46b9c5c to 0e50084CompareAugust 3, 2020 12:30
Comment threadapps/dav/tests/unit/Search/ContactsSearchProviderTest.php Outdated
Comment threadapps/dav/tests/unit/Search/ContactsSearchProviderTest.php Outdated
Comment threadapps/dav/tests/unit/Search/ContactsSearchProviderTest.php Outdated
@skjnldsv
skjnldsvforce-pushed the feature/20919/contacts_search branch from 0e50084 to 8aadd0aCompareAugust 3, 2020 12:43
@skjnldsv

Copy link
Copy Markdown
Member

Done @georgehrke

@georgehrke

Copy link
Copy Markdown
MemberAuthor

Can't approve, because i created this PR, but 👍

@skjnldsv
skjnldsvforce-pushed the feature/20919/contacts_search branch from 8aadd0a to 55ee612CompareAugust 3, 2020 12:48
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: dav feature: search and removed 3. to review Waiting for reviews labels Aug 3, 2020
@skjnldsvskjnldsv mentioned this pull request Aug 3, 2020
23 tasks
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@skjnldsv
skjnldsvforce-pushed the feature/20919/contacts_search branch from 55ee612 to 5fb2562CompareAugust 3, 2020 14:29
@skjnldsv

Copy link
Copy Markdown
Member
1) OCA\DAV\Tests\unit\ContactsSearchProviderTest::testGetId
259 | Failed asserting that two strings are equal.
260 | --- Expected
261 | +++ Actual
262 | @@ @@
263 | -'dav-contacts'
264 | +'contacts-dav'
265 | 266 | /drone/src/apps/dav/tests/unit/Search/ContactsSearchProviderTest.php:91

Fixed

@faily-bot

faily-botBot commented Aug 3, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31318: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:23
Show full log
 Scenario: share a file with another user that needs to accept shares # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section # AppNavigationContext::iOpenTheSection()
And I disable accepting the shares by default # SettingsContext::iDisableAcceptingTheSharesByDefault()
And I see that shares are not accepted by default # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
And I act as John # ActorContext::iActAs()
And I rename "welcome.txt" to "farewell.txt" # FileListContext::iRenameTo()
And I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I share "farewell.txt" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
And I accept the share for "/farewell.txt" in the notifications # NotificationsContext::iAcceptTheShareForInTheNotifications()
Notifications button in the header could not be found after 100 seconds (NoSuchElementException)
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
Then I see that the file list contains a file named "farewell.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I open the details view for "farewell.txt" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I see that the file is shared with me by "admin" # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

@skjnldsv
skjnldsv merged commit 03778d6 into masterAug 3, 2020
@skjnldsv
skjnldsv deleted the feature/20919/contacts_search branch August 3, 2020 16:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: davfeature: search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified search for addressbooks / contacts

3 participants

@georgehrke@skjnldsv@nickvergessen