Uh oh!
There was an error while loading. Please reload this page.
Add Event and Task Backends for Unified Search - #22020
Conversation
Uh oh!
There was an error while loading. Please reload this page.
7e92ba9 to
13c20bbCompareUh oh!
There was an error while loading. Please reload this page.
80a1c0e to
12674f7Compare43a276c to
8513c98CompareSigned-off-by: Georg Ehrke <developer@georgehrke.com>
8513c98 to
900617eComparegeorgehrke
commented
Aug 4, 2020
(Clicking an event in the list currently redirects to files. The link itself is correct, it's just an issue in the calendar app) |
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31359: failuresqliteShow full log |
skjnldsv
commented
Aug 4, 2020
Unrelated failures |
jancborchardt
commented
Aug 4, 2020
To solve that easily (at least I guess it’s easy) we can simply omit the year if it’s the current one. :) Less info clutter, quicker to read as well. |
| $principalUri = 'principals/users/' . $user->getUID(); | ||
| $calendarsById = $this->getSortedCalendars($principalUri); | ||
| $subscriptionsById = $this->getSortedSubscriptions($principalUri); |
There was a problem hiding this comment.
We don't show subscriptions in Tasks at the moment. I guess when a VTODO in a subscription is matched, the corresponding route in Tasks won't exist. We could also show subscriptions in the Tasks app of course, but we decided not to for now nextcloud/tasks#910.
raimund-schluessler
left a comment
There was a problem hiding this comment.
Works fine. Tasks are found as they should.
What I just noticed: @georgehrke@skjnldsv Can the |
skjnldsv
commented
Aug 4, 2020
No idea! 🤔 |
georgehrke
commented
Aug 4, 2020
We are already aware of that issue: #22092 (comment) |
georgehrke
commented
Aug 4, 2020
skjnldsv
commented
Aug 4, 2020
I have no idea, maybe try to get #22099 in so we can do followups |
jancborchardt
commented
Aug 6, 2020
Did you see that btw @georgehrke@skjnldsv – just want to make sure it doesn’t go under, as it significantly reduces the information overload there. |
skjnldsv
commented
Aug 7, 2020
Mostly for @georgehrke then :p |
Fixes#20918
Fixesnextcloud/calendar#8
I'm not super happy about the ellipsis for the Foo 4 event, but we can look into better solutions later.