Fix/unified search by skjnldsv · Pull Request #22099 · nextcloud/server

skjnldsv · 2020-08-04T08:02:06Z

Partly fixes#22092

nickvergessen · 2020-08-04T12:42:20Z

OCA\DAV\Tests\unit\ContactsSearchProviderTest::testSearch
Undefined index: iconClass

skjnldsv · 2020-08-04T13:55:37Z

Careful, I'm also working on this branch :)

faily-bot · 2020-08-04T16:08:24Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31367: failure

nodb

Show full log

There was 1 error:
1) OCA\DAV\Tests\unit\ContactsSearchProviderTest::testSearch
PHPUnit\Framework\InvalidArgumentException: Argument #1 of PHPUnit\Framework\Assert::assertInstanceOf() must be a class or interface name
/drone/src/apps/dav/tests/unit/Search/ContactsSearchProviderTest.php:219
--
There were 26 warnings:
1) Test\AppFramework\Controller\AuthPublicShareControllerTest::testAuthenticateAuthenticated
Trying to configure method "isAuthenticated" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) OCA\DAV\Tests\unit\BackgroundJob\UpdateCalendarResourcesRoomsBackgroundJobTest::testRun
Passing an array of interface names to createMock() for creating a test double that implements multiple interfaces is deprecated and will no longer be supported in PHPUnit 9.
Passing an array of interface names to getMockBuilder() for creating a test double that implements multiple interfaces is deprecated and will no longer be supported in PHPUnit 9.
3) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set
4) OCA\DAV\Tests\Command\MoveCalendarTest::testMove
Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.
5) ExpirationTest::testParseRetentionObligation with data set #0 ('disabled', null, null, null)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
6) ExpirationTest::testParseRetentionObligation with data set #1 ('auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
7) ExpirationTest::testParseRetentionObligation with data set #2 ('auto,auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
8) ExpirationTest::testParseRetentionObligation with data set #3 ('auto, auto', 30, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
9) ExpirationTest::testParseRetentionObligation with data set #4 ('auto, 3', -1, 3, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
10) ExpirationTest::testParseRetentionObligation with data set #5 ('5, auto', 5, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
11) ExpirationTest::testParseRetentionObligation with data set #6 ('3, 5', 3, 5, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
12) ExpirationTest::testParseRetentionObligation with data set #7 ('10, 3', 10, 10, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
13) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #0 ('disabled', null, null, null)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
14) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #1 ('auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
15) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #2 ('auto,auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
16) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #3 ('auto, auto', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
17) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #4 ('auto, 3', -1, 3, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
18) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #5 ('5, auto', 5, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
19) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #6 ('3, 5', 3, 5, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
20) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #7 ('10, 3', 10, 10, false)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
21) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #8 ('g,a,r,b,a,g,e', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
22) OCA\Files_Versions\Tests\ExpirationTest::testParseRetentionObligation with data set #9 ('-3,8', -1, -1, true)
assertAttributeEquals() is deprecated and will be removed in PHPUnit 9.
readAttribute() is deprecated and will be removed in PHPUnit 9.
getObjectAttribute() is deprecated and will be removed in PHPUnit 9.
23) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithPasswordResetToken
Method getTime may not return value of type string, its return declaration is ": int"
24) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_548ffe6a, its return declaration is ": void"
25) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_ea16aead, its return declaration is ": void"
26) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_ea16aead, its return declaration is ": void"

skjnldsv · 2020-08-04T16:13:27Z

There was 1 error:
OCA\DAV\Tests\unit\ContactsSearchProviderTest::testSearch
PHPUnit\Framework\InvalidArgumentException: Argument Name the repository "server" #1 of PHPUnit\Framework\Assert::assertInstanceOf() must be a class or interface name
/drone/src/apps/dav/tests/unit/Search/ContactsSearchProviderTest.php:219

@georgehrke help? 🙏

georgehrke · 2020-08-04T16:15:53Z

It seems @nickvergessen didn't fix the assertInstanceOf when making SearchResultEntry non abstract.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv · 2020-08-04T19:26:56Z

Done, let's get this in so it doesn't turn into a crazy PR™

…stract, Fix header search icon, various fixes Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

nickvergessen · 2020-08-05T11:33:01Z

+ <defs>
+ <linearGradient id="unified-search__result-placeholder-gradient">
+ <stop offset="0%" stop-color="#ededed"><animate attributeName="stop-color"
+ values="#ededed; #ededed; #cccccc; #cccccc; #ededed"


Dark mode sings:
https://www.youtube.com/watch?v=Rpq35wyDi7I

I'll fix in a followup

jancborchardt

Tested and looks good!

skjnldsv added 2. developing Work in progress enhancement feature: search labels Aug 4, 2020

skjnldsv added this to the Nextcloud 20 milestone Aug 4, 2020

skjnldsv force-pushed the fix/unified-search branch 2 times, most recently from 564e226 to 1bc542aCompare August 4, 2020 08:42

nickvergessen mentioned this pull request Aug 4, 2020
Revert "Add settings sections to unified search" #22100
Closed

nickvergessen force-pushed the fix/unified-search branch from 35faead to 80178a5Compare August 4, 2020 09:32

nickvergessen reviewed Aug 4, 2020
View reviewed changes

Comment threadlib/public/Search/IProvider.php

nickvergessen reviewed Aug 4, 2020
View reviewed changes

Comment threadlib/private/TemplateLayout.php Outdated

nickvergessen reviewed Aug 4, 2020
View reviewed changes

Comment threadlib/private/Search/SearchComposer.php

This was referenced Aug 4, 2020
App navigation via unified search #22102
Merged
Avoid empty classes #22103
Merged

nickvergessen reviewed Aug 4, 2020
View reviewed changes

Comment threadcore/src/views/UnifiedSearch.vue

Remove outdated legacy search scripts
6eced42
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv force-pushed the fix/unified-search branch from 2cb8704 to 7aa61afCompare August 4, 2020 18:57

georgehrke mentioned this pull request Aug 4, 2020
Add Event and Task Backends for Unified Search #22020
Merged

skjnldsv mentioned this pull request Aug 4, 2020
Adjust app to NC 20 and unified search nextcloud/tasks#1171
Closed

skjnldsv force-pushed the fix/unified-search branch from e435841 to 0af7698Compare August 4, 2020 19:26

skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 4, 2020

skjnldsv requested review from juliusknorr, nickvergessen and raimund-schluessler August 4, 2020 19:27

skjnldsv requested review from georgehrke and jancborchardt August 4, 2020 19:27

Show mime icon, bump bundles, make the SearchResultEntry class non-ab…
71b62c4
…stract, Fix header search icon, various fixes Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

skjnldsv force-pushed the fix/unified-search branch from 0af7698 to 71b62c4Compare August 4, 2020 19:36

skjnldsv mentioned this pull request Aug 5, 2020
Make apps handle the order logic #22104
Merged
7 tasks

nickvergessen reviewed Aug 5, 2020
View reviewed changes

nickvergessen approved these changes Aug 5, 2020
View reviewed changes

jancborchardt approved these changes Aug 5, 2020
View reviewed changes

skjnldsv merged commit a4d511d into masterAug 5, 2020

skjnldsv deleted the fix/unified-search branch August 5, 2020 12:17

skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 5, 2020

Navigation Menu

Uh oh!

Uh oh!

Fix/unified search - #22099

Fix/unified search#22099
skjnldsv merged 2 commits into
masterfrom
fix/unified-search

skjnldsv commented Aug 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickvergessen commented Aug 4, 2020

Uh oh!

skjnldsv commented Aug 4, 2020•
edited
Loading

Uh oh!

Uh oh!

faily-botBot commented Aug 4, 2020

Uh oh!

skjnldsv commented Aug 4, 2020

Uh oh!

georgehrke commented Aug 4, 2020

Uh oh!

skjnldsv commented Aug 4, 2020

Uh oh!

nickvergessenAug 5, 2020

Uh oh!

skjnldsvAug 5, 2020

Uh oh!

jancborchardt left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

skjnldsv commented Aug 4, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nickvergessen commented Aug 4, 2020

Uh oh!

skjnldsv commented Aug 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

faily-botBot commented Aug 4, 2020

Status of 31367: failure

nodb

Uh oh!

skjnldsv commented Aug 4, 2020

Uh oh!

georgehrke commented Aug 4, 2020

Uh oh!

skjnldsv commented Aug 4, 2020

Uh oh!

nickvergessenAug 5, 2020

Choose a reason for hiding this comment

Uh oh!

skjnldsvAug 5, 2020

Choose a reason for hiding this comment

Uh oh!

jancborchardt left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skjnldsv commented Aug 4, 2020•
edited
Loading