Skip to content

Make apps handle the order logic - #22104

Merged
nickvergessen merged 2 commits into
masterfrom
enh/search/make-app-handle-the-order-logic
Aug 5, 2020
Merged

Make apps handle the order logic#22104
nickvergessen merged 2 commits into
masterfrom
enh/search/make-app-handle-the-order-logic

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Aug 4, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Let the app return a lower order if the url matches its requirements!

Will be cleaner than checking against a weird id!

@skjnldsvskjnldsv added this to the Nextcloud 20 milestone Aug 4, 2020
nickvergessen
nickvergessen reviewed Aug 4, 2020
View reviewed changes
Comment threadcore/Controller/UnifiedSearchController.php Outdated
nickvergessen
nickvergessen reviewed Aug 4, 2020
View reviewed changes
Comment threadcore/Controller/UnifiedSearchController.php Outdated
nickvergessen
nickvergessen reviewed Aug 4, 2020
View reviewed changes
Comment threadapps/comments/lib/Search/CommentsSearchProvider.php Outdated
skjnldsv
skjnldsv commented Aug 4, 2020
View reviewed changes
Comment threadapps/settings/lib/Search/SectionSearch.php Outdated
@skjnldsv
skjnldsvforce-pushed the enh/search/make-app-handle-the-order-logic branch 3 times, most recently from 29865a8 to 7d6a904CompareAugust 4, 2020 19:02
@skjnldsv
skjnldsvforce-pushed the fix/unified-search branch 2 times, most recently from 0af7698 to 71b62c4CompareAugust 4, 2020 19:36
@skjnldsv
skjnldsvforce-pushed the enh/search/make-app-handle-the-order-logic branch 2 times, most recently from 0e312c0 to e97e34dCompareAugust 4, 2020 20:14
nickvergessen
nickvergessen reviewed Aug 5, 2020
View reviewed changes
Comment threadcore/Controller/UnifiedSearchController.php
@nickvergessennickvergessen mentioned this pull request Aug 5, 2020
Merged
@skjnldsv
Make apps handle the order logic
d98f7c1
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the enh/search/make-app-handle-the-order-logic branch from 1bb706c to 38621f2CompareAugust 5, 2020 09:38
@skjnldsvskjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 5, 2020
@skjnldsv

skjnldsv commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

Done, let's wait for #22099 to me merged

@skjnldsvskjnldsv mentioned this pull request Aug 5, 2020
Closed
23 tasks
Base automatically changed from fix/unified-search to masterAugust 5, 2020 12:17
@skjnldsv

skjnldsv commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

/compile amend /

@skjnldsvskjnldsv self-assigned this Aug 5, 2020
@skjnldsv

skjnldsv commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

Ready to review, compile bot incoming! 🚀

MorrisJobke
MorrisJobke approved these changes Aug 5, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@nickvergessen@npmbuildbot
Hand in the route and the parameters of the request
ea8f68b
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@npmbuildbot-nextcloud
npmbuildbot-nextcloudBotforce-pushed the enh/search/make-app-handle-the-order-logic branch from 38621f2 to ea8f68bCompareAugust 5, 2020 12:52
@skjnldsv

skjnldsv commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

All green 💚

@MorrisJobke

MorrisJobke commented Aug 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

All green 💚

Except for the second approval 😝

@skjnldsv

skjnldsv commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

Except for the second approval

I'm trying to lure some people here 😭

@nickvergessen
nickvergessen merged commit 55473dd into masterAug 5, 2020
@nickvergessen
nickvergessen deleted the enh/search/make-app-handle-the-order-logic branch August 5, 2020 14:38
@skjnldsv

skjnldsv commented Aug 5, 2020

Copy link
Copy Markdown
MemberAuthor

🤗

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 5, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@raimund-schluesslerraimund-schluesslerAwaiting requested review from raimund-schluessler
@tcitworldtcitworldAwaiting requested review from tcitworld
@jancborchardtjancborchardtAwaiting requested review from jancborchardt

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancementfeature: search

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@MorrisJobke@nickvergessen