Uh oh!
There was an error while loading. Please reload this page.
Fix share transfer of single files and on the transfered node - #22116
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
1eb8ddc to
2bbabfcCompareUh oh!
There was an error while loading. Please reload this page.
2bbabfc to
e361e0cCompareMorrisJobke
commented
Aug 11, 2020
CI says "no". |
d6974b3 to
25b9701CompareSigned-off-by: Julius Härtl <jus@bitgrid.net>
e4f77ec to
ac2999aComparejuliusknorr
commented
Aug 31, 2020
Ready for another review, since i needed to go a bit of a different way to check if a share is contained in the transferred directory. Tests seem to pass now (before the rebase). I'd actually like to extend the integration tests with some cases for this, but I'm still unable to get them to run locally, so I'd postpone this for a later point. |
danxuliu
commented
Sep 7, 2020
Actually it seems to be a problem with reshares in general. Steps to reproduce:
Expected result:fileA is reshared from user3 to user2 Actual result:fileA is still reshared from user1 to user2 |
Ah, the source path is of course not null if no path is provided. 🙈 |
Fixes#21625
This fixes an issue where shares on single file transfers or on the root folder that is being transfered could not me moved over.
There were two issues here with the current implementation:
server/lib/private/Share20/Manager.php
Lines 302 to 305 in 43efac3
Steps to reproduce:
occ files:transfer-ownership --path=f100.txt admin user2