Uh oh!
There was an error while loading. Please reload this page.
[stable18] Fix share transfer of single files and on the transfered node - #22802
Merged
Conversation
This was referenced Sep 11, 2020
juliusknorr
commented
Sep 15, 2020
MemberAuthor
Oh, thanks for taking care already @danxuliu ❤️ |
danxuliu
left a comment
Member
There was a problem hiding this comment.
Oh, thanks for taking care already @danxuliu ❤️
My pleasure :-)
Regarding the sqlite failure it is not related to this pull request. Bisecting it in my system shows that it began in #21982. However, in Drone sometimes passes and sometimes fails, so take that bisection with a pinch of salt ;-) Also it does not seem to be triggered when running only apps/files_sharing/tests/SharedMountTest.php, it seems to require running the full suite. So I do not know what is going on 🤷 But whatever it is, it is not related to this pull request :-P
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
The integration tests did not verify that the files were actually transferred between the users, only that the files were downloadable. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The integration tests did not verify that the shares were actually transferred between the users (or that they were removed due to being transferred to the sharee). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Currently only transferring ownership of a reshare with a group to a user in the group is possible. When transferring ownership of a reshare with another user or with a group to a user not in the group restoring the share fails (but the command succeeds, it only fails for the specific files that are reshares). When transferring ownership of a path that is a reshare the command fails (as when a specific path is provided the path tries to move the file, it does not take into account reshares). The added integration tests reflect the above behaviours. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
juliusknorrforce-pushed
the
backport/stable18/22116-22648-22761
branch
from
September 17, 2020 17:02
c223495 to
b6b83d6Comparejuliusknorr
requested review from
ChristophWurst, MorrisJobke, danxuliu and rullzerSeptember 17, 2020 17:03
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 33179: failuremysql8.0-php7.2Show full log |
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The files:transfer-ownership performs a sanitization of users with "risky" display names (including characters like "\" or "/"). In order to allow (escaped) double quotes in the display name the regular expression used in the "user XXX with displayname YYY exists" step is not the "standard" one, "([^"]*)". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Until recently (it was fixed in ac2999a) when a path was transferred other shares with the target user were removed, so a test was added to ensure that it does not happen again. Besides that a test to ensure that other files with the target user are not transferred was added too (it did not fail before, but seemed convenient to have that covered too :-) ). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
rullzer
approved these changes
Sep 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined backport of #22116#22648 including the new integration tests from #22761 and #22948