Skip to content

Prefer typed event over string based ones - #22169

Merged
MorrisJobke merged 1 commit into
masterfrom
enh/noid/prefer-typed-events
Aug 11, 2020
Merged

Prefer typed event over string based ones#22169
MorrisJobke merged 1 commit into
masterfrom
enh/noid/prefer-typed-events

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Aug 10, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@nextcloudnextcloud deleted a comment from faily-botBotAug 10, 2020
@MorrisJobke
MorrisJobkeforce-pushed the enh/noid/prefer-typed-events branch from e4e5048 to c0be7e3CompareAugust 10, 2020 13:23
@faily-bot

faily-botBot commented Aug 10, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31564: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
│ Details view in Files app visibility could not be got
│ Exception message: Element not found with xpath, (//html//*[@id="app-sidebar" or contains(@class, 'app-sidebar')])[1]
│ │ Unable to locate element: {"method":"xpath","selector":"(//html//*[@id=\"app-sidebar\" or contains(@class, 'app-sidebar')])[1]"}
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'e9f8d296eb89', ip: '172.22.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-88-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaaassss 😍

@MorrisJobke
MorrisJobke merged commit bc4df68 into masterAug 11, 2020
@MorrisJobke
MorrisJobke deleted the enh/noid/prefer-typed-events branch August 11, 2020 07:34
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

ref #14552

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancementtechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@ChristophWurst@skjnldsv