Skip to content

Document existing events - #2842

Merged
MorrisJobke merged 2 commits into
masterfrom
enh/noid/events
Aug 10, 2020
Merged

Document existing events#2842
MorrisJobke merged 2 commits into
masterfrom
enh/noid/events

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Aug 10, 2020

Copy link
Copy Markdown
Member

@MorrisJobke
Document existing events
da43209
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This was referenced Aug 10, 2020
Merged
Merged
@MorrisJobke

MorrisJobke commented Aug 10, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@MorrisJobke

MorrisJobke commented Aug 10, 2020

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@MorrisJobkeMorrisJobke added this to the Nextcloud 20 milestone Aug 10, 2020
@MorrisJobke
Add deprecation notice for OCP\Group\Events\BeforeUserRemovedEvent
0165943
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
ChristophWurst
ChristophWurst approved these changes Aug 10, 2020
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on the change for master/20

Not sure about the backports, though. Do we really want the newer stuff there already for stable17 and similar?

@MorrisJobke

MorrisJobke commented Aug 10, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Not sure about the backports, though. Do we really want the newer stuff there already for stable17 and similar?

I would then remove the stuff that's newer than the branch, but let the bot create the PRs. So on 18 only the stuff with "18 or later" should be present.

@MorrisJobke
MorrisJobke merged commit c52e769 into masterAug 10, 2020
@MorrisJobke
MorrisJobke deleted the enh/noid/events branch August 10, 2020 13:15
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Aug 10, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Aug 10, 2020

Copy link
Copy Markdown

The backport to stable18 failed. Please do this backport manually.

@MorrisJobkeMorrisJobke mentioned this pull request Aug 10, 2020
Merged
@MorrisJobke

MorrisJobke commented Aug 10, 2020

Copy link
Copy Markdown
MemberAuthor

#2844

@MorrisJobkeMorrisJobke mentioned this pull request Aug 10, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@georgehrkegeorgehrkeAwaiting requested review from georgehrke
@blizzzblizzzAwaiting requested review from blizzz
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@skjnldsvskjnldsvAwaiting requested review from skjnldsv
@kesselbkesselbAwaiting requested review from kesselb

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

2 participants

@MorrisJobke@ChristophWurst