provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message

[blizzz]

fixes#19097

I am not aware of any current consumers. The event is not very usable as it is fired before most apps are loaded. To keep things stable and avoid surprises nevertheless, this is the safe, backportable approach (code diverted a bit, but no biggy). With 20 and the IBootstrap bits from @ChristophWurst it should be a viable approach to subscribe to the typed event.

[blizzz]

/backport to stable19

[blizzz]

/backport to stable18

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31703: failure

acceptance-app-files

• tests/acceptance/features/app-files.feature:262

Show full log

 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

[MorrisJobke]

TBH: I couldn't find any users of this event. Let's just remove it? Why should we add an event where there is no use case? If there is one we can still add it properly.

[blizzz]

TBH: I couldn't find any users of this event. Let's just remove it? Why should we add an event where there is no use case? If there is one we can still add it properly.

There is, but the way it is pre-20 is not working, because the event is fired to early due to app loarding order.

[MorrisJobke]

There is, but the way it is pre-20 is not working, because the event is fired to early due to app loarding order.

Where?

[blizzz]

There is, but the way it is pre-20 is not working, because the event is fired to early due to app loarding order.

Where?

ldap_write_support (and upstream) would have taken advantage of it

[MorrisJobke]

Please add a deprecation notice to #20953 for 'OCA\\User_LDAP\\User\\User::postLDAPBackendAdded' and that the new event should be used.

[blizzz]

Please add a deprecation notice to #20953 for 'OCA\\User_LDAP\\User\\User::postLDAPBackendAdded' and that the new event should be used.

done

[MorrisJobke]

Please add a deprecation notice to #20953 for 'OCA\\User_LDAP\\User\\User::postLDAPBackendAdded' and that the new event should be used.

done

I added it to the table we have in that ticket

[blizzz]

Please add a deprecation notice to #20953 for 'OCA\\User_LDAP\\User\\User::postLDAPBackendAdded' and that the new event should be used.

done

I added it to the table we have in that ticket

oh, that's better. (life's too short to scroll down though 😳 )

[MorrisJobke]

ref #14552