Skip to content

[stable19] provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message - #22254

Closed
backportbot-nextcloud[bot] wants to merge 1 commit into
stable19from
backport/22221/stable19
Closed

[stable19] provide event class and typed event to LDAP loaded event; also fixing a logged deprecation message#22254
backportbot-nextcloud[bot] wants to merge 1 commit into
stable19from
backport/22221/stable19

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Aug 14, 2020

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22221

* and also dispatch the typed event as current approach to it
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@MorrisJobke

Copy link
Copy Markdown
Member

⚠️ This backport had conflicts and is incomplete ⚠️

@blizzz Mind to look into them?

@faily-bot

faily-botBot commented Aug 14, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31808: failure

integration-provisioning-v2

  • build/integration/features/provisioning-v2.feature:22
Show full log
 Scenario: Searching by displayname in groups # /drone/src/build/integration/features/provisioning-v2.feature:22
Given As an "admin" # FeatureContext::asAn()
[Fri Aug 14 14:47:34 2020] 127.0.0.1:51472 [404]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:35 2020] 127.0.0.1:51500 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:35 2020] 127.0.0.1:51604 [200]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:35 2020] 127.0.0.1:51640 [200]: /ocs/v2.php/cloud/users/user-in-group
And user "user-in-group" with displayname "specific-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:36 2020] 127.0.0.1:51680 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:36 2020] 127.0.0.1:51704 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:37 2020] 127.0.0.1:51784 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:37 2020] 127.0.0.1:51828 [200]: /ocs/v2.php/cloud/users/user-in-group2
And user "user-in-group2" with displayname "another-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:37 2020] 127.0.0.1:51864 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:38 2020] 127.0.0.1:51896 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:38 2020] 127.0.0.1:52006 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:38 2020] 127.0.0.1:52056 [200]: /ocs/v2.php/cloud/users/user-not-in-group
And user "user-not-in-group" with displayname "specific-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:39 2020] 127.0.0.1:52092 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:39 2020] 127.0.0.1:52126 [200]: /ocs/v2.php/cloud/users
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52218 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52262 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
And user "user-not-in-group2" with displayname "another-name" exists # FeatureContext::assureUserWithDisplaynameExists()
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52288 [404]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 14:47:40 2020] 127.0.0.1:52314 [200]: /ocs/v2.php/cloud/groups
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52342 [200]: /ocs/v2.php/cloud/groups/group-search
And group "group-search" exists # FeatureContext::assureGroupExists()
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52368 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52394 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Fri Aug 14 14:47:41 2020] 127.0.0.1:52422 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
And user "user-in-group" belongs to group "group-search" # FeatureContext::assureUserBelongsToGroup()
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52446 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52476 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52504 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
And user "user-in-group2" belongs to group "group-search" # FeatureContext::assureUserBelongsToGroup()
[Fri Aug 14 14:47:42 2020] 127.0.0.1:52544 [200]: /ocs/v2.php/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi
When sending "GET" to "/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi" # FeatureContext::sendingTo()
Then the OCS status code should be "200" # FeatureContext::theOCSStatusCodeShouldBe()
And the HTTP status code should be "200" # FeatureContext::theHTTPStatusCodeShouldBe()
And detailed users returned are # FeatureContext::theDetailedUsersShouldBe()
| user-in-group |
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'user-in-group'
[Fri Aug 14 14:47:43 2020] 127.0.0.1:52570 [200]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:43 2020] 127.0.0.1:52604 [404]: /ocs/v2.php/cloud/users/user-in-group
[Fri Aug 14 14:47:43 2020] 127.0.0.1:52632 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:44 2020] 127.0.0.1:52680 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Fri Aug 14 14:47:44 2020] 127.0.0.1:52712 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52766 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52808 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52850 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Fri Aug 14 14:47:45 2020] 127.0.0.1:52876 [200]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52926 [404]: /ocs/v2.php/cloud/groups/group-search
[Fri Aug 14 14:47:46 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52950 [401]: /remote.php/webdav/myFileToComment.txt
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52954 [207]: /remote.php/dav/systemtags/
[Fri Aug 14 14:47:46 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52978 [401]: /remote.php/webdav/myFileToTag.txt
[Fri Aug 14 14:47:46 2020] 127.0.0.1:52990 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Fri Aug 14 14:47:46 2020] 127.0.0.1:53038 [404]: /remote.php/dav/calendars/admin/MyCalendar

@rullzerrullzer added the 3. to review Waiting for reviews label Aug 17, 2020
@rullzerrullzer mentioned this pull request Aug 18, 2020
1 task
@MorrisJobke

Copy link
Copy Markdown
Member

log problems only -> move to 19.0.3

@blizzz

Copy link
Copy Markdown
Member

simplified backport in #22309

@blizzzblizzz closed this Aug 19, 2020
@blizzz
blizzz deleted the backport/22221/stable19 branch August 19, 2020 21:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: ldaptechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@blizzz@rullzer