Skip to content

Remove encryption option for nextcloud external storage - #22335

Merged
MorrisJobke merged 1 commit into
masterfrom
fix/16017/remove_nc_encryption
Aug 20, 2020
Merged

Remove encryption option for nextcloud external storage#22335
MorrisJobke merged 1 commit into
masterfrom
fix/16017/remove_nc_encryption

Conversation

@rullzer

Copy link
Copy Markdown
Member

Fixes#16017

Since it never worked we should not show it.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes#16017
Since it never worked we should not show it.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@rullzer

Copy link
Copy Markdown
MemberAuthor

/backport to stable17

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks better than my version 🙊

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 20, 2020
@faily-bot

faily-botBot commented Aug 20, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32100: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:262
Show full log
 Scenario: unmarking a file as favorite causes the file list to be sorted again # /drone/src/tests/acceptance/features/app-files.feature:262
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I create a new folder named "A name alphabetically lower than welcome.txt" # FileListContext::iCreateANewFolderNamed()
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
And I close the details view # FilesAppContext::iCloseTheDetailsView()
And I see that the details view is closed # FilesAppContext::iSeeThatTheDetailsViewIsClosed()
│ Details view in Files app visibility could not be got
│ Exception message: Element is no longer attached to the DOM
│ For documentation on this error, please visit: http://seleniumhq.org/exceptions/stale_element_reference.html
│ Build info: version: '2.53.1', revision: 'a36b8b1', time: '2016-06-30 17:37:03'
│ System info: host: 'bf52c24df758', ip: '172.20.0.2', os.name: 'Linux', os.arch: 'amd64', os.version: '4.15.0-88-generic', java.version: '1.8.0_91'
│ Driver info: driver.version: unknown
│ Trying again
│ And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite()
And I see that "welcome.txt" is marked as favorite # FileListContext::iSeeThatIsMarkedAsFavorite()
And I see that "welcome.txt" precedes "A name alphabetically lower than welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()
When I unmark "welcome.txt" as favorite # FileListContext::iUnmarkAsFavorite()
Then I see that "welcome.txt" is not marked as favorite # FileListContext::iSeeThatIsNotMarkedAsFavorite()
Not favorited state icon for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)
And I see that "A name alphabetically lower than welcome.txt" precedes "welcome.txt" in the file list # FileListContext::iSeeThatPrecedesInTheFileList()

acceptance-users

  • tests/acceptance/features/users.feature:25
Show full log
 Scenario: delete a user # /drone/src/tests/acceptance/features/users.feature:25
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I see that the list of users contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user user0 # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user user0 in Users Settings could not be found
Actions menu for user user0 in Users Settings could not be found (NoSuchElementException)
And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Delete user" action in the user0 actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the list of users does not contains the user user0 # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File not encrypted on external storage (Nextcloud)

4 participants

@rullzer@MorrisJobke@ChristophWurst@juliusknorr