Skip to content

[stable18] Remove encryption option for nextcloud external storage - #22343

Merged
rullzer merged 1 commit into
stable18from
backport/22335/stable18
Aug 21, 2020
Merged

[stable18] Remove encryption option for nextcloud external storage#22343
rullzer merged 1 commit into
stable18from
backport/22335/stable18

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Aug 20, 2020

Copy link
Copy Markdown

backport of #22335

@rullzer@backportbot
Remove encryption option for nextcloud external storage
bf37e4a
Fixes#16017
Since it never worked we should not show it.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 18.0.8 milestone Aug 20, 2020
@rullzerrullzer added the 3. to review Waiting for reviews label Aug 20, 2020
@faily-bot

faily-botBot commented Aug 20, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32121: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
 Scenario: show shares # /drone/src/tests/acceptance/features/app-files.feature:108
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" # FilesAppSharingContext::iShareTheLinkFor()
When I open the "Shares" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Shares" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

MorrisJobke
MorrisJobke approved these changes Aug 20, 2020
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

18.0.8 or 18.0.9?

@rullzerrullzer mentioned this pull request Aug 21, 2020
Merged
@rullzer
rullzer merged commit e1647c6 into stable18Aug 21, 2020
@rullzer
rullzer deleted the backport/22335/stable18 branch August 21, 2020 07:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@jospoortvlietjospoortvlietAwaiting requested review from jospoortvliet
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 18.0.8

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer@MorrisJobke