Skip to content

Flow: do not hide "matches" and "does not match" checkers - #22533

Merged
blizzz merged 1 commit into
masterfrom
fix/noid/rm-matcher-magic
Sep 1, 2020
Merged

Flow: do not hide "matches" and "does not match" checkers#22533
blizzz merged 1 commit into
masterfrom
fix/noid/rm-matcher-magic

Conversation

@blizzz

@blizzzblizzz commented Sep 1, 2020•
edited
Loading

Copy link
Copy Markdown
Member
  • they show up previously with "/" typed in the input field – end user needs to know about it
  • inconsistent with some other fields, that show it directly

Brought up in nextcloud/workflow_script#58

@blizzz
do not hide "matches" and "does not match" checkers
2a00c47
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added 3. to review Waiting for reviews feature: workflows papercut Annoying recurring UX issue with possibly simple fix. labels Sep 1, 2020
@blizzzblizzz added this to the Nextcloud 20 milestone Sep 1, 2020
@blizzzblizzz changed the title do not hide "matches" and "does not match" checkersFlow: do not hide "matches" and "does not match" checkersSep 1, 2020
@juliusknorrjuliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 1, 2020
@faily-bot

faily-botBot commented Sep 1, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32522: failure

mariadb10.4-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Cache\CacheTest::testExtended
Failed asserting that null matches expected 30.
/drone/src/tests/lib/Files/Cache/CacheTest.php:737

@blizzz
blizzz merged commit f32c84a into masterSep 1, 2020
@blizzz
blizzz deleted the fix/noid/rm-matcher-magic branch September 1, 2020 09:56
@rullzerrullzer mentioned this pull request Sep 3, 2020
Merged
21 tasks
@nickvergessen

nickvergessen commented Sep 21, 2020

Copy link
Copy Markdown
Member

/backport to stable19

@nickvergessen

nickvergessen commented Sep 21, 2020

Copy link
Copy Markdown
Member

/backport to stable18

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 21, 2020
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Sep 21, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorrjuliusknorrjuliusknorr approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: workflowspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 20

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@nickvergessen@juliusknorr@skjnldsv