Skip to content

[stable18] Flow: do not hide "matches" and "does not match" checkers - #22989

Merged
rullzer merged 1 commit into
stable18from
backport/22533/stable18
Oct 1, 2020
Merged

[stable18] Flow: do not hide "matches" and "does not match" checkers#22989
rullzer merged 1 commit into
stable18from
backport/22533/stable18

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Sep 21, 2020•
edited by nickvergessen
Loading

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22533

@backportbot-nextcloudbackportbot-nextcloudBot added feature: workflows papercut Annoying recurring UX issue with possibly simple fix. labels Sep 21, 2020
@nickvergessen

nickvergessen commented Sep 21, 2020

Copy link
Copy Markdown
Member

/compile amend /

@rullzerrullzer mentioned this pull request Sep 28, 2020
Merged
1 task
@blizzz@nickvergessen
do not hide "matches" and "does not match" checkers
6137466
- they show up previously with / typed – end user needs to know about it
- inconsistent with some other fields, that show it directly
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@faily-bot

faily-botBot commented Sep 29, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 33460: failure

mysql5.6-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #137 ('folder', 9, 19)
Failed asserting that false is true.
/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

@rullzer
rullzer merged commit 08e96ab into stable18Oct 1, 2020
@rullzer
rullzer deleted the backport/22533/stable18 branch October 1, 2020 06:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@blizzzblizzzAwaiting requested review from blizzz
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

feature: workflowspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 18.0.10

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@blizzz