Uh oh!
There was an error while loading. Please reload this page.
LDAP: remove unused methods and DB values - #22583
Merged
Merged
Conversation
blizzz
requested review from
ChristophWurst, juliusknorr, nickvergessen and rullzerSeptember 4, 2020 08:57
blizzz
commented
Sep 4, 2020
MemberAuthor
/backport to stable19 |
blizzz
commented
Sep 4, 2020
MemberAuthor
/backport to stable18 |
blizzzforce-pushed
the
fix/noid/remove-unused-code
branch
2 times, most recently
from
September 4, 2020 09:04
64341f1 to
18c6b98Compare
This comment has been minimized.
This comment has been minimized.
- only references were in unit tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Uh oh!
There was an error while loading. Please reload this page.
blizzzforce-pushed
the
fix/noid/remove-unused-code
branch
from
September 4, 2020 10:56
18c6b98 to
bb02c29Comparejuliusknorr
approved these changes
Sep 4, 2020
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Small naming suggestion, otherwise 👍
… prefs - also removes related app setting "updateAttributesInterval" Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzzforce-pushed
the
fix/noid/remove-unused-code
branch
from
September 4, 2020 11:00
bb02c29 to
aa2d754Compare
This was referenced Sep 6, 2020
Closed
9 tasks
4 tasks
pullBot
pushed a commit
to stefancooetzee/documentation
that referenced
this pull request
May 27, 2026
…vior The updateAttributesInterval occ config key was removed in NC20 via the RemoveRefreshTime migration (nextcloud/server#22583). The background sync interval is now auto-calculated in Jobs/Sync.php based on the number of mapped users and the minimum paging size, clamped to 30 min–12 h, targeting one full sync per day. Replace the stale "Attribute update interval" section (which still referenced the removed occ command) with an accurate description of the current auto-calculated behavior. Fixesnextcloud#11088 Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were still having the
update()method on LDAP'sUserclass as well as related values we stored with the users. In the past we changed updating of user records to happen initially (on first importing), in the background, and on login. The use case to do it inline was not given anymore.update()was now only referenced by unit tests. It made use of some other methods and also of thelastFeatureRequestmarker in the database. This is not needed anymore, and thus we do not need to write it anymore on every background run. The repair steps take care of removing these rows from the database.