Skip to content

[stable18] LDAP: remove unused methods and DB values - #22631

Merged
blizzz merged 2 commits into
stable18from
backport/22583/stable18
Sep 10, 2020
Merged

[stable18] LDAP: remove unused methods and DB values#22631
blizzz merged 2 commits into
stable18from
backport/22583/stable18

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Sep 6, 2020•
edited by blizzz
Loading

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #22583

@blizzz@backportbot
these code bits were part of old logic that was already refactored out
ea5b513
- only references were in unit tests
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 18.0.10 milestone Sep 6, 2020
@blizzz
blizzzforce-pushed the backport/22583/stable18 branch from cf53ecc to 13de2edCompareSeptember 7, 2020 09:30
@blizzz
add repair step to clean up DB off lastFeatureRefresh entries in user…
24d464c
… prefs
- also removes related app setting "updateAttributesInterval"
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
blizzzforce-pushed the backport/22583/stable18 branch from 13de2ed to 24d464cCompareSeptember 7, 2020 09:31
@faily-bot

faily-botBot commented Sep 7, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 32744: failure

postgres9-php7.3

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'
/drone/src/apps/files_versions/tests/VersioningTest.php:730

@blizzzblizzz added the 4. to release Ready to be released and/or waiting for tests to finish label Sep 10, 2020
@blizzz
blizzz merged commit a3f4b6b into stable18Sep 10, 2020
@blizzz
blizzz deleted the backport/22583/stable18 branch September 10, 2020 08:01
@rullzerrullzer mentioned this pull request Sep 28, 2020
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@juliusknorrjuliusknorrjuliusknorr approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@rullzerrullzerAwaiting requested review from rullzer

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: ldaptechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 18.0.10

Development

Successfully merging this pull request may close these issues.

2 participants

@blizzz@juliusknorr