Skip to content

Fix database password visibility toggle - #23239

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
st3iny:fix/20833/broken-dbpassword-toggle
Oct 10, 2020
Merged

Fix database password visibility toggle#23239
skjnldsv merged 1 commit into
nextcloud:masterfrom
st3iny:fix/20833/broken-dbpassword-toggle

Conversation

@st3iny

@st3inyst3iny commented Oct 6, 2020•
edited by kesselb
Loading

Copy link
Copy Markdown
Member

Fixes#20833, Fixes#22470

@st3iny

st3iny commented Oct 6, 2020

Copy link
Copy Markdown
MemberAuthor

@J0WI@MarcinWieczorek@skjnldsv Just stumbled across this bug. Your reviews are appreciated.

@J0WIJ0WI added this to the Nextcloud 19.0.5 milestone Oct 6, 2020
@J0WIJ0WI added the 3. to review Waiting for reviews label Oct 6, 2020
@J0WI
J0WI requested a review from juliusknorrOctober 6, 2020 22:59
juliusknorr
juliusknorr reviewed Oct 7, 2020
View reviewed changes
Comment threadcore/src/install.js Outdated
@juliusknorrjuliusknorr added 2. developing Work in progress bug feature: install and update and removed 3. to review Waiting for reviews labels Oct 7, 2020
@juliusknorr

juliusknorr commented Oct 7, 2020

Copy link
Copy Markdown
Member

/backport to stable20

@juliusknorr

juliusknorr commented Oct 7, 2020

Copy link
Copy Markdown
Member

/backport to stable19

@st3iny

st3iny commented Oct 7, 2020

Copy link
Copy Markdown
MemberAuthor

If you are happy with the changes I can squash the commits.

skjnldsv
skjnldsv reviewed Oct 7, 2020
View reviewed changes
Comment threadcore/templates/installation.php
@rullzer

rullzer commented Oct 8, 2020

Copy link
Copy Markdown
Member

So this is ready for review now I guess?

@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 8, 2020
@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

/compile amend /

1 similar comment
@rullzer

rullzer commented Oct 9, 2020

Copy link
Copy Markdown
Member

/compile amend /

@rullzer

rullzer commented Oct 9, 2020

Copy link
Copy Markdown
Member

@skjnldsv

07:42:25.037Z ERROR probot: Error during the compiling or the committing phase

@skjnldsv

skjnldsv commented Oct 9, 2020

Copy link
Copy Markdown
Member
07:42:25.037Z ERROR probot: Error during the compiling or the committing phase

Debug logs?

@skjnldsv

skjnldsv commented Oct 9, 2020

Copy link
Copy Markdown
Member

/compile amend /

skjnldsv
skjnldsv reviewed Oct 9, 2020
View reviewed changes
Comment threadcore/src/install.js Outdated
@skjnldsv

skjnldsv commented Oct 9, 2020

Copy link
Copy Markdown
Member

/compile amend /

1 similar comment
@skjnldsv

skjnldsv commented Oct 9, 2020

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsv

skjnldsv commented Oct 9, 2020

Copy link
Copy Markdown
Member

No more force push until the bot is finished! ⚠️

@skjnldsv

skjnldsv commented Oct 9, 2020

Copy link
Copy Markdown
Member

Ah damn, @st3iny please rebase to master drop the changes and force push again :)

@skjnldsv

skjnldsv commented Oct 10, 2020•
edited
Loading

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2020
@st3iny@npmbuildbot
Fix password visibility toggles
cb68bce
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@skjnldsv
skjnldsv merged commit 081c974 into nextcloud:masterOct 10, 2020
@welcome

welcomeBot commented Oct 10, 2020

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 10, 2020
Merged
@skjnldsv

skjnldsv commented Oct 10, 2020

Copy link
Copy Markdown
Member

/backport to stable19

@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 10, 2020

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@MorrisJobke

MorrisJobke commented Nov 3, 2020

Copy link
Copy Markdown
Member

The backport to stable19 failed. Please do this backport manually.

@skjnldsv ^

@st3iny
st3iny deleted the fix/20833/broken-dbpassword-toggle branch November 5, 2020 21:50
@J0WIJ0WI mentioned this pull request Nov 13, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsvskjnldsvskjnldsv approved these changes
@GretaDGretaDGretaD approved these changes
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: install and update

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

database password not viewable during installation nextcloud 19.0.3 and 20.0.0 [19.0] Broken dbpassword-toggle button

7 participants

@st3iny@juliusknorr@rullzer@skjnldsv@MorrisJobke@GretaD@J0WI