Skip to content

[stable20] Fix database password visibility toggle - #23336

Merged
MorrisJobke merged 1 commit into
stable20from
backport/23239/stable20
Oct 16, 2020
Merged

[stable20] Fix database password visibility toggle#23336
MorrisJobke merged 1 commit into
stable20from
backport/23239/stable20

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Oct 10, 2020•
edited
Loading

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #23239

@backportbot-nextcloudbackportbot-nextcloudBot added this to the Nextcloud 20.0.1 milestone Oct 10, 2020
@skjnldsv

skjnldsv commented Oct 10, 2020

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Oct 10, 2020
This was referenced Oct 15, 2020
Merged
Closed
@MorrisJobke
MorrisJobkeforce-pushed the backport/23239/stable20 branch from 1c672d5 to 89aeedbCompareOctober 15, 2020 11:57
@MorrisJobke

MorrisJobke commented Oct 15, 2020

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 15, 2020
@skjnldsv

skjnldsv commented Oct 15, 2020

Copy link
Copy Markdown
Member

/compile amend /

@MorrisJobke

MorrisJobke commented Oct 15, 2020

Copy link
Copy Markdown
Member

Bot says "no" :/

@skjnldsv

skjnldsv commented Oct 16, 2020

Copy link
Copy Markdown
Member

/compile amend /

@st3iny@npmbuildbot
Fix password visibility toggles
a7b0778
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@faily-bot

faily-botBot commented Oct 16, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34211: failure

acceptance-app-files

  • tests/acceptance/features/app-files.feature:108
Show full log
 Scenario: show shares # /drone/src/tests/acceptance/features/app-files.feature:108
Given I am logged in # LoginPageContext::iAmLoggedIn()
And I share the link for "welcome.txt" # FilesAppSharingContext::iShareTheLinkFor()
When I open the "Shares" section # AppNavigationContext::iOpenTheSection()
Then I see that the current section is "Shares" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

@MorrisJobke
MorrisJobke merged commit 5994f66 into stable20Oct 16, 2020
@MorrisJobke
MorrisJobke deleted the backport/23239/stable20 branch October 16, 2020 07:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GretaDGretaDGretaD approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: install and update

Projects

None yet

Milestone

Nextcloud 20.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@GretaD@st3iny