Skip to content

Fix the user remove from group in UI - #23269

Merged
skjnldsv merged 1 commit into
nextcloud:masterfrom
sharidas:fix-remove-user-from-grp
Oct 8, 2020
Merged

Fix the user remove from group in UI#23269
skjnldsv merged 1 commit into
nextcloud:masterfrom
sharidas:fix-remove-user-from-grp

Conversation

@sharidas

@sharidassharidas commented Oct 8, 2020

Copy link
Copy Markdown
Contributor

Fix the removal of user from the group in UI.

Signed-off-by: Sujith Haridasan sujith.h@gmail.com

@sharidassharidas self-assigned this Oct 8, 2020
@sharidassharidas linked an issue Oct 8, 2020 that may be closed by this pull request
Can't remove group from a user #23237
Closed
@sharidas

sharidas commented Oct 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Summary

Removal of user from the group in the UI was not working. This change set helps fix the issue.

Description

The removal of user from the group in the user management page was not happening because axios.delete expects param to be the object key in the config to get the data we are passing, i.e, the group id or gid.

Steps done to test

  1. Create a group Group1
  2. Add user user1 to Group1 in the web UI.
  3. Remove user1 from Group1 from UI. No errors are logged in the console or logfile.
  4. Verify the same with the occ, if the user is removed or not.

@sharidassharidas added the 2. developing Work in progress label Oct 8, 2020
@sharidasan
Fix the user remove from group in UI
9a286d5
Fix the removal of user from the group in UI.
Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
@sharidas
sharidasforce-pushed the fix-remove-user-from-grp branch from 0177ebe to 9a286d5CompareOctober 8, 2020 08:12
@sharidassharidas added the 3. to review Waiting for reviews label Oct 8, 2020
@sharidas
sharidas requested a review from skjnldsvOctober 8, 2020 09:18
@sharidassharidas removed the 2. developing Work in progress label Oct 8, 2020
GretaD
GretaD approved these changes Oct 8, 2020
View reviewed changes

@GretaDGretaD left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

/backport to stable20

@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

/backport to stable19

@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

/backport to stable18

@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

/compile amend /

@skjnldsv
skjnldsv merged commit d15179f into nextcloud:masterOct 8, 2020
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Oct 8, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 8, 2020

Copy link
Copy Markdown

The backport to stable19 failed. Please do this backport manually.

@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

Ah, shit, we moved the settings app, I forgot

@skjnldsvskjnldsv mentioned this pull request Oct 8, 2020
Merged
@backportbot-nextcloud

backportbot-nextcloudBot commented Oct 8, 2020

Copy link
Copy Markdown

The backport to stable18 failed. Please do this backport manually.

@skjnldsv

skjnldsv commented Oct 8, 2020

Copy link
Copy Markdown
Member

stable19 #23282

@dominikmebsdominikmebs mentioned this pull request Nov 3, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GretaDGretaDGretaD approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

@sharidassharidas

Labels

3. to reviewWaiting for reviewsbugfeature: users and groups

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't remove group from a user

4 participants

@sharidas@skjnldsv@GretaD@sharidasan