Skip to content

[stable20] Fix the user remove from group in UI - #23281

Merged
MorrisJobke merged 2 commits into
stable20from
backport/23269/stable20
Oct 12, 2020
Merged

[stable20] Fix the user remove from group in UI#23281
MorrisJobke merged 2 commits into
stable20from
backport/23269/stable20

Conversation

@backportbot-nextcloud

@backportbot-nextcloudbackportbot-nextcloudBot commented Oct 8, 2020

Copy link
Copy Markdown

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #23269

Fix the removal of user from the group in UI.
Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
@skjnldsvskjnldsv added the 3. to review Waiting for reviews label Oct 8, 2020
@nickvergessen

This comment has been minimized.

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2020
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
@nextcloudnextcloud deleted a comment from skjnldsvOct 12, 2020
@nextcloudnextcloud deleted a comment from rullzerOct 12, 2020
@faily-bot

faily-botBot commented Oct 12, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34032: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:338
Show full log
 Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
Given I act as John # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I act as Jane # ActorContext::iActAs()
And I am logged in # LoginPageContext::iAmLoggedIn()
And I act as Jim # ActorContext::iActAs()
And I am logged in as "user1" # LoginPageContext::iAmLoggedInAs()
And I act as John # ActorContext::iActAs()
And I create a new folder named "Shared folder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Shared folder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
And I share "Shared folder" with "user0" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user0" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I share "Shared folder" with "user1" # FilesAppSharingContext::iShareWith()
And I see that the file is shared with "user1" # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
And I act as John # ActorContext::iActAs()
And I set the share with "user0" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
And I see that "user0" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I create a new folder named "Subfolder" # FileListContext::iCreateANewFolderNamed()
And I see that the file list contains a file named "Subfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
When I act as Jane # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I open the details view for "Shared folder" # FileListContext::iOpenTheDetailsViewFor()
And I see that the details view is open # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
And I open the "Sharing" tab in the details view # FilesAppContext::iOpenTheTabInTheDetailsView()
And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
And I set the share with "user1" as not creatable # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
Then I see that "user1" can not create in the share # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
And I see that "user1" can not be allowed to create in the share # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
And I act as Jim # ActorContext::iActAs()
And I open the Files app # FilesAppContext::iOpenTheFilesApp()
And I enter in the folder named "Shared folder" # FileListContext::iEnterInTheFolderNamed()
And I see that it is not possible to create new files # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
Failed asserting that true is false.

@MorrisJobke
MorrisJobke merged commit f730812 into stable20Oct 12, 2020
@MorrisJobke
MorrisJobke deleted the backport/23269/stable20 branch October 12, 2020 22:29
@MorrisJobkeMorrisJobke mentioned this pull request Oct 15, 2020
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@GretaD@skjnldsv@MorrisJobke@sharidasan