Skip to content

Deprecate OCP\Util::connectHook and emitHook - #23768

Merged
MorrisJobke merged 1 commit into
masterfrom
techdebt/noid/deprecate-ocp-util-emitHook-and-connectHook
Oct 29, 2020
Merged

Deprecate OCP\Util::connectHook and emitHook#23768
MorrisJobke merged 1 commit into
masterfrom
techdebt/noid/deprecate-ocp-util-emitHook-and-connectHook

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Oct 28, 2020

Copy link
Copy Markdown
Member

typed events and the \OCP\EventDispatcher\IEventDispatcher service should be used.

Ref #14552

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@faily-bot

faily-botBot commented Oct 28, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34716: failure

acceptance-header

  • tests/acceptance/features/header.feature:33
Show full log
 Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:33
Given I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I visit the settings page # SettingsMenuContext::iVisitTheSettingsPage()
And I open the "Sharing" section of the "Administration" group # AppNavigationContext::iOpenTheSectionOf()
And I enable restricting username autocompletion to groups # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
And I see that username autocompletion is restricted to groups # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
When I open the Contacts menu # ContactsMenuContext::iOpenTheContactsMenu()
Then I see that the Contacts menu is shown # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
And I see that the contact "user0" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
Failed asserting that true is false.
And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@MorrisJobkeMorrisJobke mentioned this pull request Oct 29, 2020
@MorrisJobke
MorrisJobke merged commit 1d8b954 into masterOct 29, 2020
@MorrisJobke
MorrisJobke deleted the techdebt/noid/deprecate-ocp-util-emitHook-and-connectHook branch October 29, 2020 07:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@nickvergessen@gary-kim