Skip to content

Deprecate old user manager events for user creation - #23901

Merged
rullzer merged 1 commit into
masterfrom
techdebt/noid/deprecate-old-usermanager-events
Nov 5, 2020
Merged

Deprecate old user manager events for user creation#23901
rullzer merged 1 commit into
masterfrom
techdebt/noid/deprecate-old-usermanager-events

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Nov 4, 2020

Copy link
Copy Markdown
Member

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Nov 4, 2020
@MorrisJobkeMorrisJobke added this to the Nextcloud 21 milestone Nov 4, 2020
@faily-bot

faily-botBot commented Nov 4, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35032: failure

mariadb10.4-php7.4

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Share20\DefaultShareProviderTest::testGetSharesReshare
Failed asserting that '82' matches expected 0.
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1423

@rullzer
rullzer merged commit 12e2b74 into masterNov 5, 2020
@rullzer
rullzer deleted the techdebt/noid/deprecate-old-usermanager-events branch November 5, 2020 08:37
@ChristophWurst

Copy link
Copy Markdown
Member

Good call. #23768 should make it clear on the caller side

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@ChristophWurst@rullzer@skjnldsv