Run unit tests against oracle - #23882

Merged

nickvergessen merged 17 commits into

Nov 11, 2020

juliusknorr commented Nov 4, 2020•
edited by nickvergessen
Loading

Member

PRs split out

Fix casting to integer Fix casting to integer on Oracle #23921
Fix SQL manipulation detection Improve query type detection #23922
Fix greatest/least on oracle Fix greatest/least order for oracle #23923
Fix iLike() falsely turning escaped % and _ into wildcards Fix iLike() falsely turning escaped % and _ into wildcards #23943

Installing locally

# install php-oci8 php-pdo-oci from aur
docker run -d -p 49160:22 -p 49161:1521 deepdiver/docker-oracle-xe-11g
./occ maintenance:install --verbose --database=oci --database-name=XE --database-host=127.0.0.1 --database-port=49161 --database-user=autotest --database-pass=owncloud --admin-user admin --admin-pass admin

Tests

Seems to work though there are quite some failures:

I had a quick look at some of them but I'd welcome help from @nickvergessen here since you might know database specifics and the doctrine abstraction a bit better:

ORA-00932: inconsistent datatypes: expected - got CLOB

You can't put a CLOB in the WHERE clause. From the documentation:
Large objects (LOBs) are not supported in comparison conditions. However, you can use PL/SQL programs for comparisons on CLOB data.

ORA-01407: cannot update ("AUTOTEST"."oc_share"."password_by_talk") to NULL
Seems to be an upstream or php issue Inserting boolean "false" throws Exception with PDO_OCI doctrine/dbal#2481

juliusknorr added the 2. developing label

juliusknorr assigned nickvergessen

This comment has been minimized.

Sign in to view

nickvergessen force-pushed the tests/oracle branch 2 times, most recently from 145670e to c191597Compare

November 6, 2020 13:13

nickvergessen added this to the Nextcloud 21 milestone

nickvergessen force-pushed the tests/oracle branch 2 times, most recently from 974b8d0 to b070f68Compare

November 6, 2020 20:35

nickvergessen commented Nov 6, 2020

Member

Finally found the issue, we need to call index.php so that the instance id is generated....
Only sharing and versions have a problem remaining

nickvergessen force-pushed the tests/oracle branch 4 times, most recently from f37879a to 77cae89Compare

November 9, 2020 12:55

blizzz reviewed

View reviewed changes

lib/private/Share20/DefaultShareProvider.php

nickvergessen reviewed

View reviewed changes

core/Migrations/Version13000Date20170718121200.php Outdated

juliusknorrand others added 13 commits

November 10, 2020 15:34

Add github action for oci8

2050517

Signed-off-by: Julius Härtl <jus@bitgrid.net>

Use a different column for the primary key as we can not insert it on…

e313777

… oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>

Easier debugging and spell fix

74c0143

Signed-off-by: Joas Schilling <coding@schilljs.com>

Skip the insertIfNotExists() tests on Oracle because it doesn't work …

61c7671

…with clob
Signed-off-by: Joas Schilling <coding@schilljs.com>

Make the test pass on repeating calls

3913151

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix "Invalid fetch style: 12" on Oracle

609c8a9

Signed-off-by: Joas Schilling <coding@schilljs.com>

Make sure columns with an empty default are nullable for Oracle

ecbb066

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix public calendars as they are stored with null on oracle

31e243b

Signed-off-by: Joas Schilling <coding@schilljs.com>

Empty string is returned as null, but empty string in file cache is t…

cffad62

…he root and exists
Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix comparing the empty string for global credentials

1aa9c91

Signed-off-by: Joas Schilling <coding@schilljs.com>

Don't try to update on NotNullConstraintViolationException, only on u…

fbda2d1

…nique or foreign key
Signed-off-by: Joas Schilling <coding@schilljs.com>

Replace the credentials table with one that can have empty user

5b5aebb

Primary key columns on Oracle can not have empty strings
Signed-off-by: Joas Schilling <coding@schilljs.com>

Create primary keys on all tables and add a command to create the aft…

d5df033

…erwards
Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the tests/oracle branch from d92f6b7 to d5df033Compare

November 10, 2020 14:36

nickvergessen removed the 2. developing label

nickvergessen added bug feature: install and update labels

nickvergessen requested review from ChristophWurst, MorrisJobke, blizzz and rullzer

November 10, 2020 14:39

nickvergessen added 2 commits

November 10, 2020 15:43

Fix CS

264d54b

Signed-off-by: Joas Schilling <coding@schilljs.com>

Update baseline, I'm sorry

6883676

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen commented Nov 10, 2020

Member

/backport to stable20

backportbot-nextcloudBot added the backport-request label

skjnldsv reviewed

View reviewed changes

.github/workflows/oci.yml Outdated

skjnldsv reviewed

View reviewed changes

.github/workflows/oci.yml Outdated

ChristophWurst approved these changes

View reviewed changes

nickvergessen added 2 commits

November 10, 2020 21:39

Fix naming of jobs and steps

a524e83

Signed-off-by: Joas Schilling <coding@schilljs.com>

Fix unique key in test table

0c695d9

Signed-off-by: Joas Schilling <coding@schilljs.com>

nickvergessen force-pushed the tests/oracle branch from 8b37b9e to 0c695d9Compare

November 10, 2020 20:39

skjnldsv approved these changes

View reviewed changes

nickvergessen merged commit e39d657 into master

nickvergessen deleted the tests/oracle branch

November 11, 2020 09:05

backportbot-nextcloudBot commented Nov 11, 2020

The backport to stable20 failed. Please do this backport manually.

nickvergessen commented Nov 11, 2020

Member

Of course

nickvergessen commented Nov 11, 2020

Member

Ah, #24033 is not merged yet

nickvergessen commented Nov 11, 2020

Member

Backport to stable20 in #24049

MorrisJobke removed the backport-request label

This was referenced Nov 11, 2020

[stable20] Run unit tests against oracle #24049

Merged

MySQL Clusters prohibits use of DML commands on tables without an explicit Primary Key #16311

Closed

This comment has been minimized.

Sign in to view

MichaIng mentioned this pull request

Register new command db:add-missing-primary-keys #24085

Merged

nickvergessen mentioned this pull request

Reverted commit 54a5f938f99 because of Bug #23174 #23507

Closed

nickvergessen commented Nov 16, 2020

Member

5b5aebb broke migration for me using postgres

Fixed by #24072

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewbug feature: install and update