Skip to content

[stable20] Run unit tests against oracle - #24049

Merged
MorrisJobke merged 19 commits into
stable20from
backport/23882/stable20
Nov 12, 2020
Merged

[stable20] Run unit tests against oracle#24049
MorrisJobke merged 19 commits into
stable20from
backport/23882/stable20

Conversation

@nickvergessen

@nickvergessennickvergessen commented Nov 11, 2020•
edited by MorrisJobke
Loading

Copy link
Copy Markdown
Member

Backport of #23882

@nickvergessennickvergessen added this to the Nextcloud 20.0.2 milestone Nov 11, 2020
@nickvergessennickvergessen mentioned this pull request Nov 11, 2020
Merged
4 tasks
@MorrisJobkeMorrisJobke mentioned this pull request Nov 11, 2020
Closed
@MorrisJobke

MorrisJobke commented Nov 11, 2020

Copy link
Copy Markdown
Member

Psalm is unhappy about those two:

lib/private/Files/Stream/Encryption.php:449:16:error - UndefinedInterfaceMethod: Method OCP\Files\Cache\ICacheEntry::offsetGet does not exist
lib/private/Files/Stream/Encryption.php:501:59:error - InvalidScalarArgument: Argument 2 of OCP\Encryption\IEncryptionModule::decrypt expects string, int|non-empty-lowercase-string provided

@nickvergessen

nickvergessen commented Nov 11, 2020

Copy link
Copy Markdown
MemberAuthor

What? I updated the baseline after running it locally....

@rullzerrullzer mentioned this pull request Nov 12, 2020
Merged
juliusknorrand others added 16 commits November 12, 2020 12:57
@juliusknorr@nickvergessen
Add github action for oci8
a35b095
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@nickvergessen
Use a different column for the primary key as we can not insert it on…
f58ffad
… oracle
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Easier debugging and spell fix
3ec48cd
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Skip the insertIfNotExists() tests on Oracle because it doesn't work …
e3b3ff6
…with clob
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make the test pass on repeating calls
48c2f6d
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix "Invalid fetch style: 12" on Oracle
fcef3c0
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Make sure columns with an empty default are nullable for Oracle
8ff0523
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix public calendars as they are stored with null on oracle
b6ce689
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Empty string is returned as null, but empty string in file cache is t…
97b0402
…he root and exists
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix comparing the empty string for global credentials
a66591e
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Don't try to update on NotNullConstraintViolationException, only on u…
dee4202
…nique or foreign key
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Replace the credentials table with one that can have empty user
f3c183b
Primary key columns on Oracle can not have empty strings
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Create primary keys on all tables and add a command to create the aft…
bb52911
…erwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix CS
cd76043
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix naming of jobs and steps
07c28f1
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix unique key in test table
dabed84
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update baseline, I'm sorry
d09a220
Signed-off-by: Joas Schilling <coding@schilljs.com>
icewind1991
icewind1991 requested changes Nov 12, 2020
View reviewed changes

@icewind1991icewind1991 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires #24072 to be backported to

@icewind1991@rullzer
fix migration of oc_credentials table
388b310
Signed-off-by: Robin Appelman <robin@icewind.nl>
@rullzer

rullzer commented Nov 12, 2020

Copy link
Copy Markdown
Member

requires #24072 to be backported to

cherry-picked on this branch

@icewind1991
icewind1991 self-requested a review November 12, 2020 15:22
@faily-bot

faily-botBot commented Nov 12, 2020

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 35441: failure

mariadb10.1-php7.2

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\SystemTag\SystemTagManagerTest::testGetExistingTag with data set #1 ('one', true, false)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'0'
+'32'
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:535
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:270

@MorrisJobkeMorrisJobke mentioned this pull request Nov 12, 2020
Merged
@MorrisJobke
Update psalm-baseline
9497dca
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobke merged commit 2e3637f into stable20Nov 12, 2020
@MorrisJobke
MorrisJobke deleted the backport/23882/stable20 branch November 12, 2020 18:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst
@blizzzblizzzAwaiting requested review from blizzz
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr
@icewind1991icewind1991Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: install and update

Projects

None yet

Milestone

Nextcloud 20.0.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen@MorrisJobke@rullzer@icewind1991@juliusknorr