Skip to content

[stable9] theming app - #244

Merged
schiessle merged 3 commits into
stable9from
theming-app-stable9
Jul 1, 2016
Merged

[stable9] theming app#244
schiessle merged 3 commits into
stable9from
theming-app-stable9

Conversation

@schiessle

@schiessleschiessle commented Jun 28, 2016

Copy link
Copy Markdown
Member

backport of #59

please do some short tests, the backport needed quite some manual adjustments.

cc @LukasReschke@jancborchardt

@schiessleschiessle added this to the Nextcloud 9.0.52 milestone Jun 28, 2016
@schiessleschiessle changed the title initial commit for the theming app[stable9] theming appJun 29, 2016
@schiessle

schiessle commented Jun 29, 2016

Copy link
Copy Markdown
MemberAuthor

hm, for some reasons the file system tests fail on the backport. I tried to debug it and the difference between this branch with the last commit and without it is, that with the theming app the storage for the file system tests get wrapped by the trash bin and encryption storage which then fail because of the "dummy paths". Without the theming app this storage wrappers are not applied to the test storage... Does anyone has a idea why this could happen?

@MorrisJobke

MorrisJobke commented Jun 29, 2016

Copy link
Copy Markdown
Member

Does anyone has a idea why this could happen?

Sadly not :(

@schiessle
schiessleforce-pushed the theming-app-stable9 branch from ad8c068 to 3cb7672CompareJune 30, 2016 15:26
@nickvergessennickvergessen self-assigned this Jul 1, 2016
@nickvergessen

nickvergessen commented Jul 1, 2016

Copy link
Copy Markdown
Member

Will have a look

@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jul 1, 2016
@nickvergessen

nickvergessen commented Jul 1, 2016

Copy link
Copy Markdown
Member

Fixed, doesn't happen on master because of the LazyRootFolder.

@nickvergessennickvergessen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 1, 2016
@MorrisJobke

MorrisJobke commented Jul 1, 2016

Copy link
Copy Markdown
Member

Tested and works 👍

@schiessle

schiessle commented Jul 1, 2016

Copy link
Copy Markdown
MemberAuthor

all tests successfully passed... Thanks @nickvergessen ! 👍

@schiessle
schiessle merged commit 7e4366e into stable9Jul 1, 2016
@schiessle
schiessle deleted the theming-app-stable9 branch July 1, 2016 14:22
@MariusBluem

MariusBluem commented Jul 1, 2016

Copy link
Copy Markdown
Member

Great to see you here at Nextcloud btw 👊 @nickvergessen

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nickvergessennickvergessen

Labels

3. to reviewWaiting for reviewsfeature: theming

Projects

None yet

Milestone

Nextcloud 9.0.52

Development

Successfully merging this pull request may close these issues.

4 participants

@schiessle@MorrisJobke@nickvergessen@MariusBluem