Theming app

[jancborchardt]

@schiessle let’s get a work-in-progress pull request going here. ;)

I found 2 good color pickers:

• https://casesandberg.github.io/react-color/ seems to be the best one – Chrome style picker with alpha option removed)
• https://bebraw.github.io/colorjoe/ RGB picker with extras seems good

Also todo:

• add labels to fields
• make sure color and logos are replaced everywhere possible (favicon etc)

[MariusBluem]

Will we also integrate generating branded clients like it was possible with ownBrander?

[blizzz]

PR against master → milestone 10. backport will be 9.

[MorrisJobke]

Will we also integrate generating branded clients like it was possible with ownBrander?

Branding clients is a bit harder, because you need a huge toolchain to build it. So this is limited to the web UI for now.

[jancborchardt]

@schiessle when rebasing this against master, I get an internal server error. Can you check this out and the color picker as well?

cc @MorrisJobke@LukasReschke for JS help maybe ;)

[schiessle]

when rebasing this against master, I get an internal server error. Can you check this out and the color picker as well?

working at it at the moment. Seems to have more influences at the core as expected and also breaks initial installation at the moment. Let's see what i can do.

[schiessle]

@jancborchardt please have a look. The basic functionality is now there but we can probably improve the visual presentation.

I don't really understand why I can't update the logo directly after it was uploaded: https://github.com/nextcloud/server/pull/59/files#diff-7336f3dab52c02ef94f856620590f56bR34@blizzz do you have a idea why this doesn't work?

[blizzz]

👎 remote code execution. You can upload a PHP file as icon (e.g. phpinfo.php) and open it via http://nextcloud.server/themes/theming-app/core/img/phpinfo.php

[blizzz]

I don't really understand why I can't update the logo directly after it was uploaded: https://github.com/nextcloud/server/pull/59/files#diff-7336f3dab52c02ef94f856620590f56bR34@blizzz do you have a idea why this doesn't work?

For one, you need to wrap the path into url("…"), for the other the path was wrong. I got it working with:

logos[i].style.background="url('"+OC.getRootPath()+"/themes/theming-app/core/img/"+value+"')";

[schiessle]

Thanks @blizzz, this works!

@LukasReschke What's the best way to prevent people from uploading PHP files als background image? Maybe we can also just block all img/ paths from execution?

[blizzz]

isn't themes read-only by default?

[schiessle]

yes, I check it here https://github.com/nextcloud/server/pull/59/files#diff-d1ebf4e994bc54194a285284dda2224aR40

But good point to also add a check here to only enable the theme if we can write to the themes folder.

[LukasReschke]

As discussed with @schiessle I'll hijack this branch with some security hardenings for this feature.

[joergmschulz]

Do you already have some kind of specification document for theming? This is the area where I could help - if somebody gives me a hint for a starting point.

[schiessle]

@joergmschulz great! 😄 Did you already saw our documentation repository? Would be great to have for the administration documentation a short description of the theming app, with a screenshot and so on: https://github.com/nextcloud/documentation/tree/master/admin_manual

Would be great if you could help with this!

[jancborchardt]

@joergmschulz although the theming app ideally should be as self-explanatory as possible. :) Feedback on how it works is always good! For now we stick to the core 5 things:

• name
• website
• slogan
• color
• logo

[LukasReschke]

#59 (comment) all done

[jancborchardt]

Should I also create new issues for the other 2 points in #59 (comment) or are they planned to be fixed as part of this? cc @LukasReschke@schiessle

[MariusBluem]

at least the second point with the non-working button should be fixed here 😁

[MorrisJobke]

Tested and works 👍

[LukasReschke]

@jancborchardt check fe1089e and 4b79420. Testing appreciated.

[jancborchardt]

Great stuff! 👍 works and looks nicely now

[jancborchardt]

Yeeha, awesome work! :)