Skip to content

Don't throw a 500 when importing a broken ics reminder file - #24964

Merged
rullzer merged 1 commit into
masterfrom
bugfix/noid/internal-server-error-when-importing-broken-ics-file
Jan 5, 2021
Merged

Don't throw a 500 when importing a broken ics reminder file#24964
rullzer merged 1 commit into
masterfrom
bugfix/noid/internal-server-error-when-importing-broken-ics-file

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jan 5, 2021

Copy link
Copy Markdown
Member

Signed-off-by: Joas Schilling coding@schilljs.com

@nickvergessen
Don't throw a 500 when importing a broken ics reminder file
9fd2b60
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added this to the Nextcloud 21 milestone Jan 5, 2021
@nickvergessen

nickvergessen commented Jan 5, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable20

@nickvergessen

nickvergessen commented Jan 5, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable19

@nickvergessen

nickvergessen commented Jan 5, 2021

Copy link
Copy Markdown
MemberAuthor

/backport to stable18

@faily-bot

faily-botBot commented Jan 5, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 960: failure

mariadb10.4-php7.4

Show full log
There were 2 warnings:
1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static
--
There was 1 failure:
1) Test\Files\Config\UserMountCacheTest::testNewMounts
Failed asserting that actual size 0 matches expected size 1.
/drone/src/tests/lib/Files/Config/UserMountCacheTest.php:118

@rullzer
rullzer merged commit 50b380e into masterJan 5, 2021
@rullzer
rullzer deleted the bugfix/noid/internal-server-error-when-importing-broken-ics-file branch January 5, 2021 11:57
This was referenced Jan 5, 2021
Merged
Merged
Merged
@rullzerrullzer mentioned this pull request Jan 6, 2021
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@georgehrkegeorgehrkeAwaiting requested review from georgehrke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Milestone

Nextcloud 21

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@rullzer@ChristophWurst