Skip to content

[stable20] Don't throw a 500 when importing a broken ics reminder file - #24972

Merged
rullzer merged 1 commit into
stable20from
backport/24964/stable20
Jan 7, 2021
Merged

[stable20] Don't throw a 500 when importing a broken ics reminder file#24972
rullzer merged 1 commit into
stable20from
backport/24964/stable20

Conversation

@backportbot-nextcloud

Copy link
Copy Markdown

backport of #24964

Signed-off-by: Joas Schilling <coding@schilljs.com>
@rullzerrullzer added the 3. to review Waiting for reviews label Jan 5, 2021
@faily-bot

faily-botBot commented Jan 5, 2021

Copy link
Copy Markdown

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 969: failure

acceptance-users

  • tests/acceptance/features/users.feature:47
Show full log
 Scenario: users navigation without disabled users # /drone/src/tests/acceptance/features/users.feature:47
Given I act as Jane # ActorContext::iActAs()
And I am logged in as the admin # LoginPageContext::iAmLoggedInAsTheAdmin()
And I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
And I open the "Disabled users" section # AppNavigationContext::iOpenTheSection()
And I see that the list of users contains the user disabledUser # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
And I open the actions menu for the user disabledUser # UsersSettingsContext::iOpenTheActionsMenuOf()
Row for user disabledUser in Users Settings could not be found
Actions menu for user disabledUser in Users Settings could not be found (NoSuchElementException)
And I see that the "Enable user" action in the disabledUser actions menu is shown # UsersSettingsContext::iSeeTheAction()
When I click the "Enable user" action in the disabledUser actions menu # UsersSettingsContext::iClickTheAction()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()
When I open the User settings # SettingsMenuContext::iOpenTheUserSettings()
Then I see that the section "Disabled users" is not shown # AppNavigationContext::iSeeThatTheSectionIsNotShown()

@rullzerrullzer mentioned this pull request Jan 6, 2021
1 task
@rullzer
rullzer merged commit 9e6cc31 into stable20Jan 7, 2021
@rullzer
rullzer deleted the backport/24964/stable20 branch January 7, 2021 08:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rullzer@nickvergessen