Skip to content

Fix ldap css and jquery ui css fix for menu dropdown - #2529

Closed
skjnldsv wants to merge 5 commits into
masterfrom
fix-ldap-css
Closed

Fix ldap css and jquery ui css fix for menu dropdown#2529
skjnldsv wants to merge 5 commits into
masterfrom
fix-ldap-css

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Dec 6, 2016

Copy link
Copy Markdown
Member

refs: #1932#1780#2524

capture d ecran_2016-12-06_13-14-42

@MorrisJobke @nextcloud/designers

@skjnldsvskjnldsv added 3. to review Waiting for reviews bug design Design, UI, UX, etc. enhancement labels Dec 6, 2016
@skjnldsvskjnldsv added this to the Nextcloud 11.0 milestone Dec 6, 2016
@mention-bot

Copy link
Copy Markdown

@skjnldsv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @jancborchardt and @individual-it to be potential reviewers.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv

skjnldsv commented Dec 6, 2016

Copy link
Copy Markdown
MemberAuthor

Rebased and ready to merge! 🚀

@MorrisJobke

Copy link
Copy Markdown
Member

@blizzz Could you have a look at this?

@codecov-io

Copy link
Copy Markdown

Current coverage is 57.21% (diff: 20.00%)

Merging #2529 into master will increase coverage by <.01%

@@ master #2529 diff @@
==========================================
Files 1202 1202 Lines 72470 72466 -4 Methods 7365 7365 Messages 0 0 Branches 1228 1228 ==========================================
+ Hits 41463 41465 +2 + Misses 31007 31001 -6 
Partials 0 0 
Diff CoverageFile Path
0%apps/user_ldap/templates/part.wizard-server.php
•••••••••• 100%lib/private/legacy/template.php

Powered by Codecov. Last update b190153...f07e4a0

@blizzz

Copy link
Copy Markdown
Member

Advanced tab does not use the available space properly:

spectacle a18316

Looks good otherwise!

@LukasReschke

Copy link
Copy Markdown
Member

@skjnldsv Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges.

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@LukasReschke If you want! :)
It'w not really a game-changing pr ;)

@LukasReschke

Copy link
Copy Markdown
Member

Ok. – Master is open again so I suppose we need to fix #2529 (comment) and then can merge this?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

@LukasReschke Exactly. I didn't had the time yet.

@skjnldsvskjnldsv self-assigned this Dec 18, 2016
@MorrisJobkeMorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 22, 2016
@LukasReschke

Copy link
Copy Markdown
Member

@skjnldsv Is this still interesting? If not we should probably close this 😉

@skjnldsv

skjnldsv commented Feb 20, 2017

Copy link
Copy Markdown
MemberAuthor

I need to rework this with the scss :)
Leave it open 🎉

@jancborchardtjancborchardt added this to the Nextcloud 13 milestone Apr 25, 2017
@jancborchardtjancborchardt removed this from the Nextcloud 12.0 milestone Apr 25, 2017
@jancborchardt

Copy link
Copy Markdown
Member

Moving to Nextcloud 13 then as we have feature freeze tomorrow. :)

@MorrisJobke

Copy link
Copy Markdown
Member

@skjnldsv I guess most of this in here was fixed by #6341 - can we close this then?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Ehheh, yes we can! 💪

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressbugdesignDesign, UI, UX, etc.enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@skjnldsv@mention-bot@MorrisJobke@codecov-io@blizzz@LukasReschke@jancborchardt